Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4040)

Unified Diff: chrome/browser/ui/android/usb_chooser_dialog_android.cc

Issue 2448943002: Refactor SecurityStateModel/Clients for simplicity and reusability. (Closed)
Patch Set: refactor -> SecurityStateTabHelper. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/usb_chooser_dialog_android.cc
diff --git a/chrome/browser/ui/android/usb_chooser_dialog_android.cc b/chrome/browser/ui/android/usb_chooser_dialog_android.cc
index 19bba9c4afd9ba76d78f24fa782fd3474573044f..d3c17372420314ccede9c26cb86854741ca51e2c 100644
--- a/chrome/browser/ui/android/usb_chooser_dialog_android.cc
+++ b/chrome/browser/ui/android/usb_chooser_dialog_android.cc
@@ -13,7 +13,7 @@
#include "base/bind.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/profiles/profile.h"
-#include "chrome/browser/ssl/chrome_security_state_model_client.h"
+#include "chrome/browser/ssl/security_state_tab_helper.h"
#include "chrome/browser/usb/usb_chooser_context.h"
#include "chrome/browser/usb/usb_chooser_context_factory.h"
#include "chrome/browser/usb/web_usb_histograms.h"
@@ -77,11 +77,11 @@ UsbChooserDialogAndroid::UsbChooserDialogAndroid(
base::android::ConvertUTF16ToJavaString(
env, url_formatter::FormatUrlForSecurityDisplay(GURL(
render_frame_host->GetLastCommittedOrigin().Serialize())));
- ChromeSecurityStateModelClient* security_model_client =
- ChromeSecurityStateModelClient::FromWebContents(web_contents);
- DCHECK(security_model_client);
+ SecurityStateTabHelper* helper =
+ SecurityStateTabHelper::FromWebContents(web_contents);
+ DCHECK(helper);
security_state::SecurityStateModel::SecurityInfo security_info;
- security_model_client->GetSecurityInfo(&security_info);
+ helper->GetSecurityInfo(&security_info);
java_dialog_.Reset(Java_UsbChooserDialog_create(
env, window_android, origin_string, security_info.security_level,
reinterpret_cast<intptr_t>(this)));

Powered by Google App Engine
This is Rietveld 408576698