Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Unified Diff: components/security_state/core/security_state_model.h

Issue 2448943002: Refactor SecurityStateModel/Clients for simplicity and reusability. (Closed)
Patch Set: Remove *SecurityModelClient. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/security_state/core/security_state_model.h
diff --git a/components/security_state/security_state_model.h b/components/security_state/core/security_state_model.h
similarity index 93%
rename from components/security_state/security_state_model.h
rename to components/security_state/core/security_state_model.h
index 235c6b5e224211fe15b3e8b59c893d6fda2f05e4..252c892052ee350f2ad6b036c2ccda710c8d3f26 100644
--- a/components/security_state/security_state_model.h
+++ b/components/security_state/core/security_state_model.h
@@ -6,6 +6,7 @@
#define COMPONENTS_SECURITY_STATE_SECURITY_STATE_MODEL_H_
#include <stdint.h>
+#include <memory>
#include "base/macros.h"
#include "net/cert/cert_status_flags.h"
@@ -15,7 +16,8 @@
namespace security_state {
-class SecurityStateModelClient;
+// Returns true if the given |url|'s origin should be considered secure.
+bool IsOriginSecure(const GURL& url);
// SecurityStateModel provides high-level security information about a
// page or request.
@@ -144,7 +146,7 @@ class SecurityStateModel {
// Contains the security state relevant to computing the SecurityInfo
// for a page. This is the input to GetSecurityInfo() provided by the
- // model's client.
+ // model's user.
struct VisibleSecurityState {
VisibleSecurityState();
~VisibleSecurityState();
@@ -195,13 +197,15 @@ class SecurityStateModel {
virtual ~SecurityStateModel();
// Populates |result| to describe the current page.
- void GetSecurityInfo(SecurityInfo* result) const;
-
- void SetClient(SecurityStateModelClient* client);
+ // |visible_security_state| contains the relevant security state.
+ // |used_policy_installed_certificate| indicates whether the page or request
+ // is known to be loaded with a certificate installed by the system admin.
+ void GetSecurityInfo(
+ SecurityInfo* result,
+ std::unique_ptr<VisibleSecurityState> visible_security_state,
+ bool used_policy_installed_certificate) const;
private:
- SecurityStateModelClient* client_;
-
DISALLOW_COPY_AND_ASSIGN(SecurityStateModel);
};

Powered by Google App Engine
This is Rietveld 408576698