components/security_state/core/security_state_model.cc - Issue 2448943002: Refactor SecurityStateModel/Clients for simplicity and reusability.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/security_state/core/security_state_model.cc

Issue 2448943002: Refactor SecurityStateModel/Clients for simplicity and reusability. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/security_state/content/web_contents_security_state_model_client.h ('K') | « components/security_state/core/security_state_model.h ('k') | components/security_state/core/security_state_model_client.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "components/security_state/security_state_model.h"	5 #include "components/security_state/core/security_state_model.h"

6	6

7 #include <stdint.h>	7 #include <stdint.h>

8	8

9 #include "base/command_line.h"	9 #include "base/command_line.h"

10 #include "base/metrics/field_trial.h"	10 #include "base/metrics/field_trial.h"

11 #include "base/metrics/histogram_macros.h"	11 #include "base/metrics/histogram_macros.h"

12 #include "components/security_state/security_state_model_client.h"	12 #include "components/security_state/core/security_state_model_client.h"

13 #include "components/security_state/switches.h"	13 #include "components/security_state/core/switches.h"

14 #include "net/ssl/ssl_cipher_suite_names.h"	14 #include "net/ssl/ssl_cipher_suite_names.h"

15 #include "net/ssl/ssl_connection_status_flags.h"	15 #include "net/ssl/ssl_connection_status_flags.h"

16	16

17 namespace security_state {	17 namespace security_state {

18	18

19 namespace {	19 namespace {

20	20

21 // Do not change or reorder this enum, and add new values at the end. It is used	21 // Do not change or reorder this enum, and add new values at the end. It is used

22 // in the MarkHttpAs histogram.	22 // in the MarkHttpAs histogram.

23 enum MarkHttpStatus { NEUTRAL, NON_SECURE, HTTP_SHOW_WARNING, LAST_STATUS };	23 enum MarkHttpStatus { NEUTRAL, NON_SECURE, HTTP_SHOW_WARNING, LAST_STATUS };

(...skipping 301 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
325 other.displayed_content_with_cert_errors &&	325 other.displayed_content_with_cert_errors &&

326 ran_content_with_cert_errors == other.ran_content_with_cert_errors &&	326 ran_content_with_cert_errors == other.ran_content_with_cert_errors &&

327 pkp_bypassed == other.pkp_bypassed &&	327 pkp_bypassed == other.pkp_bypassed &&

328 displayed_password_field_on_http ==	328 displayed_password_field_on_http ==

329 other.displayed_password_field_on_http &&	329 other.displayed_password_field_on_http &&

330 displayed_credit_card_field_on_http ==	330 displayed_credit_card_field_on_http ==

331 other.displayed_credit_card_field_on_http);	331 other.displayed_credit_card_field_on_http);

332 }	332 }

333	333

334 } // namespace security_state	334 } // namespace security_state

OLD	NEW