Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Side by Side Diff: chrome/browser/ui/views/browser_dialogs_views_mac.cc

Issue 2448943002: Refactor SecurityStateModel/Clients for simplicity and reusability. (Closed)
Patch Set: sync. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <utility> 5 #include <utility>
6 6
7 #include "chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.h" 7 #include "chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.h"
8 #include "chrome/browser/ui/browser.h" 8 #include "chrome/browser/ui/browser.h"
9 #include "chrome/browser/ui/browser_dialogs.h" 9 #include "chrome/browser/ui/browser_dialogs.h"
10 #include "chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h" 10 #include "chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h"
11 #include "chrome/browser/ui/views/content_setting_bubble_contents.h" 11 #include "chrome/browser/ui/views/content_setting_bubble_contents.h"
12 #include "chrome/browser/ui/views/task_manager_view.h" 12 #include "chrome/browser/ui/views/task_manager_view.h"
13 #include "chrome/browser/ui/views/website_settings/website_settings_popup_view.h " 13 #include "chrome/browser/ui/views/website_settings/website_settings_popup_view.h "
14 14
15 // This file provides definitions of desktop browser dialog-creation methods for 15 // This file provides definitions of desktop browser dialog-creation methods for
16 // Mac where a Cocoa browser is using Views dialogs. I.e. it is included in the 16 // Mac where a Cocoa browser is using Views dialogs. I.e. it is included in the
17 // Cocoa build and definitions under chrome/browser/ui/cocoa may select at 17 // Cocoa build and definitions under chrome/browser/ui/cocoa may select at
18 // runtime whether to show a Cocoa dialog, or the toolkit-views dialog defined 18 // runtime whether to show a Cocoa dialog, or the toolkit-views dialog defined
19 // here (declared in browser_dialogs.h). 19 // here (declared in browser_dialogs.h).
20 20
21 namespace chrome { 21 namespace chrome {
22 22
23 void ShowWebsiteSettingsBubbleViewsAtPoint( 23 void ShowWebsiteSettingsBubbleViewsAtPoint(
24 const gfx::Point& anchor_point, 24 const gfx::Point& anchor_point,
25 Profile* profile, 25 Profile* profile,
26 content::WebContents* web_contents, 26 content::WebContents* web_contents,
27 const GURL& virtual_url, 27 const GURL& virtual_url,
28 const security_state::SecurityStateModel::SecurityInfo& security_info) { 28 const security_state::SecurityInfo& security_info) {
29 // Don't show the bubble again if it's already showing. A second click on the 29 // Don't show the bubble again if it's already showing. A second click on the
30 // location icon in the omnibox will dismiss an open bubble. This behaviour is 30 // location icon in the omnibox will dismiss an open bubble. This behaviour is
31 // consistent with the non-Mac views implementation. 31 // consistent with the non-Mac views implementation.
32 // Note that when the browser is toolkit-views, IsPopupShowing() is checked 32 // Note that when the browser is toolkit-views, IsPopupShowing() is checked
33 // earlier because the popup is shown on mouse release (but dismissed on 33 // earlier because the popup is shown on mouse release (but dismissed on
34 // mouse pressed). A Cocoa browser does both on mouse pressed, so a check 34 // mouse pressed). A Cocoa browser does both on mouse pressed, so a check
35 // when showing is sufficient. 35 // when showing is sufficient.
36 if (WebsiteSettingsPopupView::GetShownPopupType() != 36 if (WebsiteSettingsPopupView::GetShownPopupType() !=
37 WebsiteSettingsPopupView::POPUP_NONE) { 37 WebsiteSettingsPopupView::POPUP_NONE) {
38 return; 38 return;
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 const gfx::Point& anchor) { 75 const gfx::Point& anchor) {
76 ContentSettingBubbleContents* contents = 76 ContentSettingBubbleContents* contents =
77 new ContentSettingBubbleContents(model, web_contents, nullptr, 77 new ContentSettingBubbleContents(model, web_contents, nullptr,
78 views::BubbleBorder::Arrow::TOP_RIGHT); 78 views::BubbleBorder::Arrow::TOP_RIGHT);
79 contents->set_parent_window(parent_view); 79 contents->set_parent_window(parent_view);
80 contents->SetAnchorRect(gfx::Rect(anchor, gfx::Size())); 80 contents->SetAnchorRect(gfx::Rect(anchor, gfx::Size()));
81 views::BubbleDialogDelegateView::CreateBubble(contents)->Show(); 81 views::BubbleDialogDelegateView::CreateBubble(contents)->Show();
82 } 82 }
83 83
84 } // namespace chrome 84 } // namespace chrome
OLDNEW
« no previous file with comments | « chrome/browser/ui/toolbar/chrome_toolbar_model_delegate.cc ('k') | chrome/browser/ui/views/frame/browser_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698