Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Side by Side Diff: chrome/browser/ui/android/usb_chooser_dialog_android.cc

Issue 2448943002: Refactor SecurityStateModel/Clients for simplicity and reusability. (Closed)
Patch Set: sync. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/android/usb_chooser_dialog_android.h" 5 #include "chrome/browser/ui/android/usb_chooser_dialog_android.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <algorithm> 9 #include <algorithm>
10 10
11 #include "base/android/jni_android.h" 11 #include "base/android/jni_android.h"
12 #include "base/android/jni_string.h" 12 #include "base/android/jni_string.h"
13 #include "base/bind.h" 13 #include "base/bind.h"
14 #include "base/strings/utf_string_conversions.h" 14 #include "base/strings/utf_string_conversions.h"
15 #include "chrome/browser/profiles/profile.h" 15 #include "chrome/browser/profiles/profile.h"
16 #include "chrome/browser/ssl/chrome_security_state_model_client.h" 16 #include "chrome/browser/ssl/security_state_tab_helper.h"
17 #include "chrome/browser/usb/usb_chooser_context.h" 17 #include "chrome/browser/usb/usb_chooser_context.h"
18 #include "chrome/browser/usb/usb_chooser_context_factory.h" 18 #include "chrome/browser/usb/usb_chooser_context_factory.h"
19 #include "chrome/browser/usb/web_usb_histograms.h" 19 #include "chrome/browser/usb/web_usb_histograms.h"
20 #include "chrome/common/url_constants.h" 20 #include "chrome/common/url_constants.h"
21 #include "components/security_state/core/security_state.h"
21 #include "components/url_formatter/elide_url.h" 22 #include "components/url_formatter/elide_url.h"
22 #include "content/public/browser/android/content_view_core.h" 23 #include "content/public/browser/android/content_view_core.h"
23 #include "content/public/browser/render_frame_host.h" 24 #include "content/public/browser/render_frame_host.h"
24 #include "content/public/browser/web_contents.h" 25 #include "content/public/browser/web_contents.h"
25 #include "device/base/device_client.h" 26 #include "device/base/device_client.h"
26 #include "device/usb/mojo/type_converters.h" 27 #include "device/usb/mojo/type_converters.h"
27 #include "device/usb/usb_device.h" 28 #include "device/usb/usb_device.h"
28 #include "device/usb/usb_device_filter.h" 29 #include "device/usb/usb_device_filter.h"
29 #include "device/usb/webusb_descriptors.h" 30 #include "device/usb/webusb_descriptors.h"
30 #include "jni/UsbChooserDialog_jni.h" 31 #include "jni/UsbChooserDialog_jni.h"
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 content::WebContents::FromRenderFrameHost(render_frame_host_); 71 content::WebContents::FromRenderFrameHost(render_frame_host_);
71 base::android::ScopedJavaLocalRef<jobject> window_android = 72 base::android::ScopedJavaLocalRef<jobject> window_android =
72 content::ContentViewCore::FromWebContents(web_contents) 73 content::ContentViewCore::FromWebContents(web_contents)
73 ->GetWindowAndroid() 74 ->GetWindowAndroid()
74 ->GetJavaObject(); 75 ->GetJavaObject();
75 JNIEnv* env = base::android::AttachCurrentThread(); 76 JNIEnv* env = base::android::AttachCurrentThread();
76 base::android::ScopedJavaLocalRef<jstring> origin_string = 77 base::android::ScopedJavaLocalRef<jstring> origin_string =
77 base::android::ConvertUTF16ToJavaString( 78 base::android::ConvertUTF16ToJavaString(
78 env, url_formatter::FormatUrlForSecurityDisplay(GURL( 79 env, url_formatter::FormatUrlForSecurityDisplay(GURL(
79 render_frame_host->GetLastCommittedOrigin().Serialize()))); 80 render_frame_host->GetLastCommittedOrigin().Serialize())));
80 ChromeSecurityStateModelClient* security_model_client = 81 SecurityStateTabHelper* helper =
81 ChromeSecurityStateModelClient::FromWebContents(web_contents); 82 SecurityStateTabHelper::FromWebContents(web_contents);
82 DCHECK(security_model_client); 83 DCHECK(helper);
83 security_state::SecurityStateModel::SecurityInfo security_info; 84 security_state::SecurityInfo security_info;
84 security_model_client->GetSecurityInfo(&security_info); 85 helper->GetSecurityInfo(&security_info);
85 java_dialog_.Reset(Java_UsbChooserDialog_create( 86 java_dialog_.Reset(Java_UsbChooserDialog_create(
86 env, window_android, origin_string, security_info.security_level, 87 env, window_android, origin_string, security_info.security_level,
87 reinterpret_cast<intptr_t>(this))); 88 reinterpret_cast<intptr_t>(this)));
88 89
89 if (!java_dialog_.is_null()) { 90 if (!java_dialog_.is_null()) {
90 usb_service->GetDevices( 91 usb_service->GetDevices(
91 base::Bind(&UsbChooserDialogAndroid::GotUsbDeviceList, 92 base::Bind(&UsbChooserDialogAndroid::GotUsbDeviceList,
92 weak_factory_.GetWeakPtr())); 93 weak_factory_.GetWeakPtr()));
93 } 94 }
94 } 95 }
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
236 237
237 return device::FindInWebUsbAllowedOrigins( 238 return device::FindInWebUsbAllowedOrigins(
238 device->webusb_allowed_origins(), 239 device->webusb_allowed_origins(),
239 render_frame_host_->GetLastCommittedURL().GetOrigin()); 240 render_frame_host_->GetLastCommittedURL().GetOrigin());
240 } 241 }
241 242
242 // static 243 // static
243 bool UsbChooserDialogAndroid::Register(JNIEnv* env) { 244 bool UsbChooserDialogAndroid::Register(JNIEnv* env) {
244 return RegisterNativesImpl(env); 245 return RegisterNativesImpl(env);
245 } 246 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/android/page_info/website_settings_popup_android.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698