Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Side by Side Diff: chrome/browser/ui/website_settings/website_settings.cc

Issue 2448943002: Refactor SecurityStateModel/Clients for simplicity and reusability. (Closed)
Patch Set: fix DEPS. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/website_settings/website_settings.h" 5 #include "chrome/browser/ui/website_settings/website_settings.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <string> 10 #include <string>
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 75
76 #if !defined(OS_ANDROID) 76 #if !defined(OS_ANDROID)
77 #include "chrome/browser/ui/exclusive_access/exclusive_access_manager.h" 77 #include "chrome/browser/ui/exclusive_access/exclusive_access_manager.h"
78 #include "chrome/browser/ui/website_settings/website_settings_infobar_delegate.h " 78 #include "chrome/browser/ui/website_settings/website_settings_infobar_delegate.h "
79 #endif 79 #endif
80 80
81 using base::ASCIIToUTF16; 81 using base::ASCIIToUTF16;
82 using base::UTF8ToUTF16; 82 using base::UTF8ToUTF16;
83 using base::UTF16ToUTF8; 83 using base::UTF16ToUTF8;
84 using content::BrowserThread; 84 using content::BrowserThread;
85 using security_state::SecurityStateModel;
86 85
87 namespace { 86 namespace {
88 87
89 // Events for UMA. Do not reorder or change! 88 // Events for UMA. Do not reorder or change!
90 enum SSLCertificateDecisionsDidRevoke { 89 enum SSLCertificateDecisionsDidRevoke {
91 USER_CERT_DECISIONS_NOT_REVOKED = 0, 90 USER_CERT_DECISIONS_NOT_REVOKED = 0,
92 USER_CERT_DECISIONS_REVOKED, 91 USER_CERT_DECISIONS_REVOKED,
93 END_OF_SSL_CERTIFICATE_DECISIONS_DID_REVOKE_ENUM 92 END_OF_SSL_CERTIFICATE_DECISIONS_DID_REVOKE_ENUM
94 }; 93 };
95 94
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 if (type == CONTENT_SETTINGS_TYPE_AUTOPLAY || 129 if (type == CONTENT_SETTINGS_TYPE_AUTOPLAY ||
131 type == CONTENT_SETTINGS_TYPE_FULLSCREEN || 130 type == CONTENT_SETTINGS_TYPE_FULLSCREEN ||
132 type == CONTENT_SETTINGS_TYPE_MOUSELOCK) { 131 type == CONTENT_SETTINGS_TYPE_MOUSELOCK) {
133 return false; 132 return false;
134 } 133 }
135 #endif 134 #endif
136 135
137 return true; 136 return true;
138 } 137 }
139 138
140 void CheckContentStatus(SecurityStateModel::ContentStatus content_status, 139 void CheckContentStatus(security_state::ContentStatus content_status,
141 bool* displayed, 140 bool* displayed,
142 bool* ran) { 141 bool* ran) {
143 switch (content_status) { 142 switch (content_status) {
144 case SecurityStateModel::CONTENT_STATUS_DISPLAYED: 143 case security_state::CONTENT_STATUS_DISPLAYED:
145 *displayed = true; 144 *displayed = true;
146 break; 145 break;
147 case SecurityStateModel::CONTENT_STATUS_RAN: 146 case security_state::CONTENT_STATUS_RAN:
148 *ran = true; 147 *ran = true;
149 break; 148 break;
150 case SecurityStateModel::CONTENT_STATUS_DISPLAYED_AND_RAN: 149 case security_state::CONTENT_STATUS_DISPLAYED_AND_RAN:
151 *displayed = true; 150 *displayed = true;
152 *ran = true; 151 *ran = true;
153 break; 152 break;
154 case SecurityStateModel::CONTENT_STATUS_UNKNOWN: 153 case security_state::CONTENT_STATUS_UNKNOWN:
155 case SecurityStateModel::CONTENT_STATUS_NONE: 154 case security_state::CONTENT_STATUS_NONE:
156 break; 155 break;
157 } 156 }
158 } 157 }
159 158
160 void CheckForInsecureContent( 159 void CheckForInsecureContent(
161 const SecurityStateModel::SecurityInfo& security_info, 160 const security_state::SecurityInfo& security_info,
162 bool* displayed, 161 bool* displayed,
163 bool* ran) { 162 bool* ran) {
164 CheckContentStatus(security_info.mixed_content_status, displayed, ran); 163 CheckContentStatus(security_info.mixed_content_status, displayed, ran);
165 // Only consider subresources with certificate errors if the main 164 // Only consider subresources with certificate errors if the main
166 // resource was loaded over HTTPS without major certificate errors. If 165 // resource was loaded over HTTPS without major certificate errors. If
167 // the main resource had a certificate error, then it would not be 166 // the main resource had a certificate error, then it would not be
168 // that useful (and would potentially be confusing) to warn about 167 // that useful (and would potentially be confusing) to warn about
169 // subesources that had certificate errors too. 168 // subesources that had certificate errors too.
170 if (net::IsCertStatusError(security_info.cert_status) && 169 if (net::IsCertStatusError(security_info.cert_status) &&
171 !net::IsCertStatusMinorError(security_info.cert_status)) { 170 !net::IsCertStatusMinorError(security_info.cert_status)) {
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
248 }; 247 };
249 248
250 } // namespace 249 } // namespace
251 250
252 WebsiteSettings::WebsiteSettings( 251 WebsiteSettings::WebsiteSettings(
253 WebsiteSettingsUI* ui, 252 WebsiteSettingsUI* ui,
254 Profile* profile, 253 Profile* profile,
255 TabSpecificContentSettings* tab_specific_content_settings, 254 TabSpecificContentSettings* tab_specific_content_settings,
256 content::WebContents* web_contents, 255 content::WebContents* web_contents,
257 const GURL& url, 256 const GURL& url,
258 const SecurityStateModel::SecurityInfo& security_info) 257 const security_state::SecurityInfo& security_info)
259 : TabSpecificContentSettings::SiteDataObserver( 258 : TabSpecificContentSettings::SiteDataObserver(
260 tab_specific_content_settings), 259 tab_specific_content_settings),
261 content::WebContentsObserver(web_contents), 260 content::WebContentsObserver(web_contents),
262 ui_(ui), 261 ui_(ui),
263 show_info_bar_(false), 262 show_info_bar_(false),
264 site_url_(url), 263 site_url_(url),
265 site_identity_status_(SITE_IDENTITY_STATUS_UNKNOWN), 264 site_identity_status_(SITE_IDENTITY_STATUS_UNKNOWN),
266 site_connection_status_(SITE_CONNECTION_STATUS_UNKNOWN), 265 site_connection_status_(SITE_CONNECTION_STATUS_UNKNOWN),
267 show_ssl_decision_revoke_button_(false), 266 show_ssl_decision_revoke_button_(false),
268 content_settings_(HostContentSettingsMapFactory::GetForProfile(profile)), 267 content_settings_(HostContentSettingsMapFactory::GetForProfile(profile)),
269 chrome_ssl_host_state_delegate_( 268 chrome_ssl_host_state_delegate_(
270 ChromeSSLHostStateDelegateFactory::GetForProfile(profile)), 269 ChromeSSLHostStateDelegateFactory::GetForProfile(profile)),
271 did_revoke_user_ssl_decisions_(false), 270 did_revoke_user_ssl_decisions_(false),
272 profile_(profile), 271 profile_(profile),
273 security_level_(security_state::SecurityStateModel::NONE) { 272 security_level_(security_state::NONE) {
274 Init(url, security_info); 273 Init(url, security_info);
275 274
276 PresentSitePermissions(); 275 PresentSitePermissions();
277 PresentSiteData(); 276 PresentSiteData();
278 PresentSiteIdentity(); 277 PresentSiteIdentity();
279 278
280 // Every time the Website Settings UI is opened a |WebsiteSettings| object is 279 // Every time the Website Settings UI is opened a |WebsiteSettings| object is
281 // created. So this counts how ofter the Website Settings UI is opened. 280 // created. So this counts how ofter the Website Settings UI is opened.
282 RecordWebsiteSettingsAction(WEBSITE_SETTINGS_OPENED); 281 RecordWebsiteSettingsAction(WEBSITE_SETTINGS_OPENED);
283 } 282 }
284 283
285 WebsiteSettings::~WebsiteSettings() { 284 WebsiteSettings::~WebsiteSettings() {
286 } 285 }
287 286
288 void WebsiteSettings::RecordWebsiteSettingsAction( 287 void WebsiteSettings::RecordWebsiteSettingsAction(
289 WebsiteSettingsAction action) { 288 WebsiteSettingsAction action) {
290 UMA_HISTOGRAM_ENUMERATION("WebsiteSettings.Action", 289 UMA_HISTOGRAM_ENUMERATION("WebsiteSettings.Action",
291 action, 290 action,
292 WEBSITE_SETTINGS_COUNT); 291 WEBSITE_SETTINGS_COUNT);
293 292
294 std::string histogram_name; 293 std::string histogram_name;
295 294
296 if (site_url_.SchemeIsCryptographic()) { 295 if (site_url_.SchemeIsCryptographic()) {
297 if (security_level_ == security_state::SecurityStateModel::SECURE || 296 if (security_level_ == security_state::SECURE ||
298 security_level_ == security_state::SecurityStateModel::EV_SECURE) { 297 security_level_ == security_state::EV_SECURE) {
299 UMA_HISTOGRAM_ENUMERATION("Security.PageInfo.Action.HttpsUrl.Valid", 298 UMA_HISTOGRAM_ENUMERATION("Security.PageInfo.Action.HttpsUrl.Valid",
300 action, WEBSITE_SETTINGS_COUNT); 299 action, WEBSITE_SETTINGS_COUNT);
301 } else if (security_level_ == security_state::SecurityStateModel::NONE) { 300 } else if (security_level_ == security_state::NONE) {
302 UMA_HISTOGRAM_ENUMERATION("Security.PageInfo.Action.HttpsUrl.Downgraded", 301 UMA_HISTOGRAM_ENUMERATION("Security.PageInfo.Action.HttpsUrl.Downgraded",
303 action, WEBSITE_SETTINGS_COUNT); 302 action, WEBSITE_SETTINGS_COUNT);
304 } else if (security_level_ == 303 } else if (security_level_ == security_state::DANGEROUS) {
305 security_state::SecurityStateModel::DANGEROUS) {
306 UMA_HISTOGRAM_ENUMERATION("Security.PageInfo.Action.HttpsUrl.Dangerous", 304 UMA_HISTOGRAM_ENUMERATION("Security.PageInfo.Action.HttpsUrl.Dangerous",
307 action, WEBSITE_SETTINGS_COUNT); 305 action, WEBSITE_SETTINGS_COUNT);
308 } 306 }
309 return; 307 return;
310 } 308 }
311 309
312 if (security_level_ == 310 if (security_level_ == security_state::HTTP_SHOW_WARNING) {
313 security_state::SecurityStateModel::HTTP_SHOW_WARNING) {
314 UMA_HISTOGRAM_ENUMERATION("Security.PageInfo.Action.HttpUrl.Warning", 311 UMA_HISTOGRAM_ENUMERATION("Security.PageInfo.Action.HttpUrl.Warning",
315 action, WEBSITE_SETTINGS_COUNT); 312 action, WEBSITE_SETTINGS_COUNT);
316 } else if (security_level_ == security_state::SecurityStateModel::DANGEROUS) { 313 } else if (security_level_ == security_state::DANGEROUS) {
317 UMA_HISTOGRAM_ENUMERATION("Security.PageInfo.Action.HttpUrl.Dangerous", 314 UMA_HISTOGRAM_ENUMERATION("Security.PageInfo.Action.HttpUrl.Dangerous",
318 action, WEBSITE_SETTINGS_COUNT); 315 action, WEBSITE_SETTINGS_COUNT);
319 } else { 316 } else {
320 UMA_HISTOGRAM_ENUMERATION("Security.PageInfo.Action.HttpUrl.Neutral", 317 UMA_HISTOGRAM_ENUMERATION("Security.PageInfo.Action.HttpUrl.Neutral",
321 action, WEBSITE_SETTINGS_COUNT); 318 action, WEBSITE_SETTINGS_COUNT);
322 } 319 }
323 } 320 }
324 321
325 void WebsiteSettings::OnSitePermissionChanged(ContentSettingsType type, 322 void WebsiteSettings::OnSitePermissionChanged(ContentSettingsType type,
326 ContentSetting setting) { 323 ContentSetting setting) {
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
404 #endif 401 #endif
405 } 402 }
406 403
407 void WebsiteSettings::OnRevokeSSLErrorBypassButtonPressed() { 404 void WebsiteSettings::OnRevokeSSLErrorBypassButtonPressed() {
408 DCHECK(chrome_ssl_host_state_delegate_); 405 DCHECK(chrome_ssl_host_state_delegate_);
409 chrome_ssl_host_state_delegate_->RevokeUserAllowExceptionsHard( 406 chrome_ssl_host_state_delegate_->RevokeUserAllowExceptionsHard(
410 site_url().host()); 407 site_url().host());
411 did_revoke_user_ssl_decisions_ = true; 408 did_revoke_user_ssl_decisions_ = true;
412 } 409 }
413 410
414 void WebsiteSettings::Init( 411 void WebsiteSettings::Init(const GURL& url,
415 const GURL& url, 412 const security_state::SecurityInfo& security_info) {
416 const SecurityStateModel::SecurityInfo& security_info) {
417 #if !defined(OS_ANDROID) && !defined(OS_IOS) 413 #if !defined(OS_ANDROID) && !defined(OS_IOS)
418 // On desktop, internal URLs aren't handled by this class. Instead, a 414 // On desktop, internal URLs aren't handled by this class. Instead, a
419 // custom and simpler popup is shown. 415 // custom and simpler popup is shown.
420 DCHECK(!url.SchemeIs(content::kChromeUIScheme) && 416 DCHECK(!url.SchemeIs(content::kChromeUIScheme) &&
421 !url.SchemeIs(content::kChromeDevToolsScheme) && 417 !url.SchemeIs(content::kChromeDevToolsScheme) &&
422 !url.SchemeIs(content::kViewSourceScheme) && 418 !url.SchemeIs(content::kViewSourceScheme) &&
423 !url.SchemeIs(content_settings::kExtensionScheme)); 419 !url.SchemeIs(content_settings::kExtensionScheme));
424 #endif 420 #endif
425 421
426 bool isChromeUINativeScheme = false; 422 bool isChromeUINativeScheme = false;
(...skipping 26 matching lines...) Expand all
453 449
454 // Identity section. 450 // Identity section.
455 certificate_ = security_info.certificate; 451 certificate_ = security_info.certificate;
456 452
457 // HTTPS with no or minor errors. 453 // HTTPS with no or minor errors.
458 if (certificate_ && 454 if (certificate_ &&
459 (!net::IsCertStatusError(security_info.cert_status) || 455 (!net::IsCertStatusError(security_info.cert_status) ||
460 net::IsCertStatusMinorError(security_info.cert_status))) { 456 net::IsCertStatusMinorError(security_info.cert_status))) {
461 // There are no major errors. Check for minor errors. 457 // There are no major errors. Check for minor errors.
462 if (security_info.security_level == 458 if (security_info.security_level ==
463 SecurityStateModel::SECURE_WITH_POLICY_INSTALLED_CERT) { 459 security_state::SECURE_WITH_POLICY_INSTALLED_CERT) {
464 site_identity_status_ = SITE_IDENTITY_STATUS_ADMIN_PROVIDED_CERT; 460 site_identity_status_ = SITE_IDENTITY_STATUS_ADMIN_PROVIDED_CERT;
465 site_identity_details_ = l10n_util::GetStringFUTF16( 461 site_identity_details_ = l10n_util::GetStringFUTF16(
466 IDS_CERT_POLICY_PROVIDED_CERT_MESSAGE, UTF8ToUTF16(url.host())); 462 IDS_CERT_POLICY_PROVIDED_CERT_MESSAGE, UTF8ToUTF16(url.host()));
467 } else if (net::IsCertStatusMinorError(security_info.cert_status)) { 463 } else if (net::IsCertStatusMinorError(security_info.cert_status)) {
468 site_identity_status_ = SITE_IDENTITY_STATUS_CERT_REVOCATION_UNKNOWN; 464 site_identity_status_ = SITE_IDENTITY_STATUS_CERT_REVOCATION_UNKNOWN;
469 base::string16 issuer_name( 465 base::string16 issuer_name(
470 UTF8ToUTF16(certificate_->issuer().GetDisplayName())); 466 UTF8ToUTF16(certificate_->issuer().GetDisplayName()));
471 if (issuer_name.empty()) { 467 if (issuer_name.empty()) {
472 issuer_name.assign(l10n_util::GetStringUTF16( 468 issuer_name.assign(l10n_util::GetStringUTF16(
473 IDS_PAGE_INFO_SECURITY_TAB_UNKNOWN_PARTY)); 469 IDS_PAGE_INFO_SECURITY_TAB_UNKNOWN_PARTY));
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
532 issuer_name.assign(l10n_util::GetStringUTF16( 528 issuer_name.assign(l10n_util::GetStringUTF16(
533 IDS_PAGE_INFO_SECURITY_TAB_UNKNOWN_PARTY)); 529 IDS_PAGE_INFO_SECURITY_TAB_UNKNOWN_PARTY));
534 } 530 }
535 531
536 site_identity_details_.assign(l10n_util::GetStringFUTF16( 532 site_identity_details_.assign(l10n_util::GetStringFUTF16(
537 GetSiteIdentityDetailsMessageByCTInfo( 533 GetSiteIdentityDetailsMessageByCTInfo(
538 security_info.sct_verify_statuses, false /* not EV */), 534 security_info.sct_verify_statuses, false /* not EV */),
539 issuer_name)); 535 issuer_name));
540 } 536 }
541 switch (security_info.sha1_deprecation_status) { 537 switch (security_info.sha1_deprecation_status) {
542 case SecurityStateModel::DEPRECATED_SHA1_MINOR: 538 case security_state::DEPRECATED_SHA1_MINOR:
543 site_identity_status_ = 539 site_identity_status_ =
544 SITE_IDENTITY_STATUS_DEPRECATED_SIGNATURE_ALGORITHM_MINOR; 540 SITE_IDENTITY_STATUS_DEPRECATED_SIGNATURE_ALGORITHM_MINOR;
545 site_identity_details_ += 541 site_identity_details_ +=
546 UTF8ToUTF16("\n\n") + 542 UTF8ToUTF16("\n\n") +
547 l10n_util::GetStringUTF16( 543 l10n_util::GetStringUTF16(
548 IDS_PAGE_INFO_SECURITY_TAB_DEPRECATED_SIGNATURE_ALGORITHM_MINO R); 544 IDS_PAGE_INFO_SECURITY_TAB_DEPRECATED_SIGNATURE_ALGORITHM_MINO R);
549 break; 545 break;
550 case SecurityStateModel::DEPRECATED_SHA1_MAJOR: 546 case security_state::DEPRECATED_SHA1_MAJOR:
551 site_identity_status_ = 547 site_identity_status_ =
552 SITE_IDENTITY_STATUS_DEPRECATED_SIGNATURE_ALGORITHM_MAJOR; 548 SITE_IDENTITY_STATUS_DEPRECATED_SIGNATURE_ALGORITHM_MAJOR;
553 site_identity_details_ += 549 site_identity_details_ +=
554 UTF8ToUTF16("\n\n") + 550 UTF8ToUTF16("\n\n") +
555 l10n_util::GetStringUTF16( 551 l10n_util::GetStringUTF16(
556 IDS_PAGE_INFO_SECURITY_TAB_DEPRECATED_SIGNATURE_ALGORITHM_MAJO R); 552 IDS_PAGE_INFO_SECURITY_TAB_DEPRECATED_SIGNATURE_ALGORITHM_MAJO R);
557 break; 553 break;
558 case SecurityStateModel::NO_DEPRECATED_SHA1: 554 case security_state::NO_DEPRECATED_SHA1:
559 // Nothing to do. 555 // Nothing to do.
560 break; 556 break;
561 case SecurityStateModel::UNKNOWN_SHA1: 557 case security_state::UNKNOWN_SHA1:
562 // UNKNOWN_SHA1 should only appear when certificate info has not been 558 // UNKNOWN_SHA1 should only appear when certificate info has not been
563 // initialized, in which case this if-statement should not be running 559 // initialized, in which case this if-statement should not be running
564 // because there is no other cert info. 560 // because there is no other cert info.
565 NOTREACHED(); 561 NOTREACHED();
566 } 562 }
567 } 563 }
568 } else { 564 } else {
569 // HTTP or HTTPS with errors (not warnings). 565 // HTTP or HTTPS with errors (not warnings).
570 site_identity_details_.assign(l10n_util::GetStringUTF16( 566 site_identity_details_.assign(l10n_util::GetStringUTF16(
571 IDS_PAGE_INFO_SECURITY_TAB_INSECURE_IDENTITY)); 567 IDS_PAGE_INFO_SECURITY_TAB_INSECURE_IDENTITY));
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
607 // loaded over HTTP or loaded over HTTPS with no cert. 603 // loaded over HTTP or loaded over HTTPS with no cert.
608 site_connection_status_ = SITE_CONNECTION_STATUS_UNENCRYPTED; 604 site_connection_status_ = SITE_CONNECTION_STATUS_UNENCRYPTED;
609 605
610 site_connection_details_.assign(l10n_util::GetStringFUTF16( 606 site_connection_details_.assign(l10n_util::GetStringFUTF16(
611 IDS_PAGE_INFO_SECURITY_TAB_NOT_ENCRYPTED_CONNECTION_TEXT, 607 IDS_PAGE_INFO_SECURITY_TAB_NOT_ENCRYPTED_CONNECTION_TEXT,
612 subject_name)); 608 subject_name));
613 } else if (security_info.security_bits < 0) { 609 } else if (security_info.security_bits < 0) {
614 // Security strength is unknown. Say nothing. 610 // Security strength is unknown. Say nothing.
615 site_connection_status_ = SITE_CONNECTION_STATUS_ENCRYPTED_ERROR; 611 site_connection_status_ = SITE_CONNECTION_STATUS_ENCRYPTED_ERROR;
616 } else if (security_info.security_bits == 0) { 612 } else if (security_info.security_bits == 0) {
617 DCHECK_NE(security_info.security_level, SecurityStateModel::NONE); 613 DCHECK_NE(security_info.security_level, security_state::NONE);
618 site_connection_status_ = SITE_CONNECTION_STATUS_ENCRYPTED_ERROR; 614 site_connection_status_ = SITE_CONNECTION_STATUS_ENCRYPTED_ERROR;
619 site_connection_details_.assign(l10n_util::GetStringFUTF16( 615 site_connection_details_.assign(l10n_util::GetStringFUTF16(
620 IDS_PAGE_INFO_SECURITY_TAB_NOT_ENCRYPTED_CONNECTION_TEXT, 616 IDS_PAGE_INFO_SECURITY_TAB_NOT_ENCRYPTED_CONNECTION_TEXT,
621 subject_name)); 617 subject_name));
622 } else { 618 } else {
623 site_connection_status_ = SITE_CONNECTION_STATUS_ENCRYPTED; 619 site_connection_status_ = SITE_CONNECTION_STATUS_ENCRYPTED;
624 620
625 if (security_info.obsolete_ssl_status == net::OBSOLETE_SSL_NONE) { 621 if (security_info.obsolete_ssl_status == net::OBSOLETE_SSL_NONE) {
626 site_connection_details_.assign(l10n_util::GetStringFUTF16( 622 site_connection_details_.assign(l10n_util::GetStringFUTF16(
627 IDS_PAGE_INFO_SECURITY_TAB_ENCRYPTED_CONNECTION_TEXT, 623 IDS_PAGE_INFO_SECURITY_TAB_ENCRYPTED_CONNECTION_TEXT,
(...skipping 210 matching lines...) Expand 10 before | Expand all | Expand 10 after
838 info.connection_status = site_connection_status_; 834 info.connection_status = site_connection_status_;
839 info.connection_status_description = 835 info.connection_status_description =
840 UTF16ToUTF8(site_connection_details_); 836 UTF16ToUTF8(site_connection_details_);
841 info.identity_status = site_identity_status_; 837 info.identity_status = site_identity_status_;
842 info.identity_status_description = 838 info.identity_status_description =
843 UTF16ToUTF8(site_identity_details_); 839 UTF16ToUTF8(site_identity_details_);
844 info.certificate = certificate_; 840 info.certificate = certificate_;
845 info.show_ssl_decision_revoke_button = show_ssl_decision_revoke_button_; 841 info.show_ssl_decision_revoke_button = show_ssl_decision_revoke_button_;
846 ui_->SetIdentityInfo(info); 842 ui_->SetIdentityInfo(info);
847 } 843 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698