Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Side by Side Diff: chrome/browser/ui/android/bluetooth_chooser_android.cc

Issue 2448943002: Refactor SecurityStateModel/Clients for simplicity and reusability. (Closed)
Patch Set: update comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/android/bluetooth_chooser_android.h" 5 #include "chrome/browser/ui/android/bluetooth_chooser_android.h"
6 6
7 #include "base/android/jni_android.h" 7 #include "base/android/jni_android.h"
8 #include "base/android/jni_string.h" 8 #include "base/android/jni_string.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "chrome/browser/ssl/chrome_security_state_model_client.h" 10 #include "chrome/browser/ssl/security_state_tab_helper.h"
11 #include "chrome/common/url_constants.h" 11 #include "chrome/common/url_constants.h"
12 #include "components/url_formatter/elide_url.h" 12 #include "components/url_formatter/elide_url.h"
13 #include "content/public/browser/android/content_view_core.h" 13 #include "content/public/browser/android/content_view_core.h"
14 #include "content/public/browser/render_frame_host.h" 14 #include "content/public/browser/render_frame_host.h"
15 #include "jni/BluetoothChooserDialog_jni.h" 15 #include "jni/BluetoothChooserDialog_jni.h"
16 #include "ui/android/window_android.h" 16 #include "ui/android/window_android.h"
17 #include "url/gurl.h" 17 #include "url/gurl.h"
18 #include "url/origin.h" 18 #include "url/origin.h"
19 19
20 using base::android::AttachCurrentThread; 20 using base::android::AttachCurrentThread;
21 using base::android::ConvertUTF8ToJavaString; 21 using base::android::ConvertUTF8ToJavaString;
22 using base::android::ConvertUTF16ToJavaString; 22 using base::android::ConvertUTF16ToJavaString;
23 using base::android::JavaParamRef; 23 using base::android::JavaParamRef;
24 using base::android::ScopedJavaLocalRef; 24 using base::android::ScopedJavaLocalRef;
25 25
26 BluetoothChooserAndroid::BluetoothChooserAndroid( 26 BluetoothChooserAndroid::BluetoothChooserAndroid(
27 content::RenderFrameHost* frame, 27 content::RenderFrameHost* frame,
28 const EventHandler& event_handler) 28 const EventHandler& event_handler)
29 : web_contents_(content::WebContents::FromRenderFrameHost(frame)), 29 : web_contents_(content::WebContents::FromRenderFrameHost(frame)),
30 event_handler_(event_handler) { 30 event_handler_(event_handler) {
31 const url::Origin origin = frame->GetLastCommittedOrigin(); 31 const url::Origin origin = frame->GetLastCommittedOrigin();
32 DCHECK(!origin.unique()); 32 DCHECK(!origin.unique());
33 33
34 base::android::ScopedJavaLocalRef<jobject> window_android = 34 base::android::ScopedJavaLocalRef<jobject> window_android =
35 content::ContentViewCore::FromWebContents(web_contents_) 35 content::ContentViewCore::FromWebContents(web_contents_)
36 ->GetWindowAndroid() 36 ->GetWindowAndroid()
37 ->GetJavaObject(); 37 ->GetJavaObject();
38 38
39 ChromeSecurityStateModelClient* security_model_client = 39 SecurityStateTabHelper* helper =
40 ChromeSecurityStateModelClient::FromWebContents(web_contents_); 40 SecurityStateTabHelper::FromWebContents(web_contents_);
41 DCHECK(security_model_client); 41 DCHECK(helper);
42 42
43 // Create (and show) the BluetoothChooser dialog. 43 // Create (and show) the BluetoothChooser dialog.
44 JNIEnv* env = AttachCurrentThread(); 44 JNIEnv* env = AttachCurrentThread();
45 base::android::ScopedJavaLocalRef<jstring> origin_string = 45 base::android::ScopedJavaLocalRef<jstring> origin_string =
46 base::android::ConvertUTF16ToJavaString( 46 base::android::ConvertUTF16ToJavaString(
47 env, url_formatter::FormatUrlForSecurityDisplay(origin.GetURL())); 47 env, url_formatter::FormatUrlForSecurityDisplay(origin.GetURL()));
48 security_state::SecurityStateModel::SecurityInfo security_info; 48 security_state::SecurityStateModel::SecurityInfo security_info;
49 security_model_client->GetSecurityInfo(&security_info); 49 helper->GetSecurityInfo(&security_info);
50 java_dialog_.Reset(Java_BluetoothChooserDialog_create( 50 java_dialog_.Reset(Java_BluetoothChooserDialog_create(
51 env, window_android, origin_string, security_info.security_level, 51 env, window_android, origin_string, security_info.security_level,
52 reinterpret_cast<intptr_t>(this))); 52 reinterpret_cast<intptr_t>(this)));
53 } 53 }
54 54
55 BluetoothChooserAndroid::~BluetoothChooserAndroid() { 55 BluetoothChooserAndroid::~BluetoothChooserAndroid() {
56 if (!java_dialog_.is_null()) { 56 if (!java_dialog_.is_null()) {
57 Java_BluetoothChooserDialog_closeDialog(AttachCurrentThread(), 57 Java_BluetoothChooserDialog_closeDialog(AttachCurrentThread(),
58 java_dialog_); 58 java_dialog_);
59 } 59 }
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 // static 170 // static
171 bool BluetoothChooserAndroid::Register(JNIEnv* env) { 171 bool BluetoothChooserAndroid::Register(JNIEnv* env) {
172 return RegisterNativesImpl(env); 172 return RegisterNativesImpl(env);
173 } 173 }
174 174
175 void BluetoothChooserAndroid::OpenURL(const char* url) { 175 void BluetoothChooserAndroid::OpenURL(const char* url) {
176 web_contents_->OpenURL(content::OpenURLParams( 176 web_contents_->OpenURL(content::OpenURLParams(
177 GURL(url), content::Referrer(), WindowOpenDisposition::NEW_FOREGROUND_TAB, 177 GURL(url), content::Referrer(), WindowOpenDisposition::NEW_FOREGROUND_TAB,
178 ui::PAGE_TRANSITION_AUTO_TOPLEVEL, false /* is_renderer_initiated */)); 178 ui::PAGE_TRANSITION_AUTO_TOPLEVEL, false /* is_renderer_initiated */));
179 } 179 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698