Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Unified Diff: src/objects.h

Issue 2448933002: [compiler] Make SFI "optimize" flag a "tier up" flag (Closed)
Patch Set: Do some renaming and remove a DCHECK Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/flag-definitions.h ('k') | src/objects.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index ef3f31df4793aefb3cdfbc7012a9c889589b8fb7..75cafc86e0ac7fc36b5b6061356f7c0c7ea00eed 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -7668,8 +7668,8 @@ class SharedFunctionInfo: public HeapObject {
// Whether this function was created from a FunctionDeclaration.
DECL_BOOLEAN_ACCESSORS(is_declaration)
- // Whether this function was marked to be optimized.
- DECL_BOOLEAN_ACCESSORS(was_marked_for_optimization)
+ // Whether this function was marked to be tiered up.
+ DECL_BOOLEAN_ACCESSORS(marked_for_tier_up)
// Indicates that asm->wasm conversion failed and should not be re-attempted.
DECL_BOOLEAN_ACCESSORS(is_asm_wasm_broken)
@@ -7920,7 +7920,7 @@ class SharedFunctionInfo: public HeapObject {
enum CompilerHints {
// byte 0
kAllowLazyCompilation,
- kWasMarkedForOptimization,
+ kMarkedForTierUp,
kOptimizationDisabled,
kNeverCompiled,
kNative,
@@ -7988,8 +7988,8 @@ class SharedFunctionInfo: public HeapObject {
static const int kAllFunctionKindBitsMask = FunctionKindBits::kMask
<< kCompilerHintsSmiTagSize;
- static const int kWasMarkedForOptimizationBit =
- kWasMarkedForOptimization + kCompilerHintsSmiTagSize;
+ static const int kMarkedForTierUpBit =
+ kMarkedForTierUp + kCompilerHintsSmiTagSize;
// Constants for optimizing codegen for strict mode function and
// native tests.
@@ -8003,8 +8003,8 @@ class SharedFunctionInfo: public HeapObject {
FunctionKind::kClassConstructor << kCompilerHintsSmiTagSize;
STATIC_ASSERT(kClassConstructorBitsWithinByte < (1 << kBitsPerByte));
- static const int kWasMarkedForOptimizationBitWithinByte =
- kWasMarkedForOptimizationBit % kBitsPerByte;
+ static const int kMarkedForTierUpBitWithinByte =
+ kMarkedForTierUpBit % kBitsPerByte;
#if defined(V8_TARGET_LITTLE_ENDIAN)
#define BYTE_OFFSET(compiler_hint) \
@@ -8022,8 +8022,7 @@ class SharedFunctionInfo: public HeapObject {
static const int kFunctionKindByteOffset = BYTE_OFFSET(kFunctionKind);
static const int kHasDuplicateParametersByteOffset =
BYTE_OFFSET(kHasDuplicateParameters);
- static const int kWasMarkedForOptimizationByteOffset =
- BYTE_OFFSET(kWasMarkedForOptimization);
+ static const int kMarkedForTierUpByteOffset = BYTE_OFFSET(kMarkedForTierUp);
#undef BYTE_OFFSET
private:
« no previous file with comments | « src/flag-definitions.h ('k') | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698