Issue 244893005: Speed-up whitelist check in data_pack.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 244893005: Speed-up whitelist check in data_pack.py (Closed)

Created:
6 years, 8 months ago by aurimas (slooooooooow)

Modified:
6 years, 8 months ago

Reviewers:
Nico, newt (away)

CC:
grit-developer_googlegroups.com

Base URL:
https://chromium.googlesource.com/external/grit-i18n.git@master

Visibility:
Public.

More Reviews

Description

Speed-up whitelist check in data_pack.py Previously whitelist was passed as a list causing a slow down when doing 'key in whitelist' check. Converting the list to a set to speed that up. Local testing shows about 4x speedup in running RePack(). BUG=338759 R=thakis@chromium.org Committed: https://code.google.com/p/grit-i18n/source/detail?r=166

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	grit/format/data_pack.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

aurimas (slooooooooow)

Hey Newton, Can you land this for me, please? Thanks! Aurimas

6 years, 8 months ago (2014-04-21 21:29:46 UTC) #3

newt (away)

6 years, 8 months ago (2014-04-21 22:10:13 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r166 (presubmit successful).

Expand Messages | Collapse Messages