Improve some naming

chrome/browser/themes/theme_service_aurax11.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/themes/theme_service_aurax11.h"
 
 #include "base/bind.h"
 #include "base/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/themes/custom_theme_supplier.h"
 #include "chrome/common/pref_names.h"
 #include "ui/gfx/image/image.h"
 #include "ui/views/linux_ui/linux_ui.h"
 
 namespace {
 
-class NativeThemeX11 : public CustomThemeSupplier {
+class SystemThemeX11 : public CustomThemeSupplier {
  public:
-  explicit NativeThemeX11(PrefService* pref_service);
+  explicit SystemThemeX11(PrefService* pref_service);
 
   // Overridden from CustomThemeSupplier:
   virtual void StartUsingTheme() OVERRIDE;
   virtual void StopUsingTheme() OVERRIDE;
   virtual bool GetColor(int id, SkColor* color) const OVERRIDE;
   virtual gfx::Image GetImageNamed(int id) OVERRIDE;
   virtual bool HasCustomImage(int id) const OVERRIDE;
 
  private:
-  virtual ~NativeThemeX11();
+  virtual ~SystemThemeX11();
 
   // These pointers are not owned by us.
   views::LinuxUI* const linux_ui_;
   PrefService* const pref_service_;
 
-  DISALLOW_COPY_AND_ASSIGN(NativeThemeX11);
+  DISALLOW_COPY_AND_ASSIGN(SystemThemeX11);
 };
 
-NativeThemeX11::NativeThemeX11(PrefService* pref_service)
+SystemThemeX11::SystemThemeX11(PrefService* pref_service)
     : CustomThemeSupplier(NATIVE_X11),
       linux_ui_(views::LinuxUI::instance()),
       pref_service_(pref_service) {}
 
-void NativeThemeX11::StartUsingTheme() {
+void SystemThemeX11::StartUsingTheme() {
   pref_service_->SetBoolean(prefs::kUsesSystemTheme, true);
 }
 
-void NativeThemeX11::StopUsingTheme() {
+void SystemThemeX11::StopUsingTheme() {
   pref_service_->SetBoolean(prefs::kUsesSystemTheme, false);
 }
 
-bool NativeThemeX11::GetColor(int id, SkColor* color) const {
+bool SystemThemeX11::GetColor(int id, SkColor* color) const {
   return linux_ui_ && linux_ui_->GetColor(id, color);
 }
 
-gfx::Image NativeThemeX11::GetImageNamed(int id) {
+gfx::Image SystemThemeX11::GetImageNamed(int id) {
   return linux_ui_ ? linux_ui_->GetThemeImageNamed(id) : gfx::Image();
 }
 
-bool NativeThemeX11::HasCustomImage(int id) const {
+bool SystemThemeX11::HasCustomImage(int id) const {
   return linux_ui_ && linux_ui_->HasCustomImage(id);
 }
 
-NativeThemeX11::~NativeThemeX11() {}
+SystemThemeX11::~SystemThemeX11() {}
 
 }  // namespace
 
 ThemeServiceAuraX11::ThemeServiceAuraX11() {
   views::LinuxUI* linux_ui = views::LinuxUI::instance();
   if (linux_ui)
-    linux_ui->AddNativeThemeChangeObserver(this);
+    linux_ui->AddSystemThemeChangeObserver(this);
 }
 
 ThemeServiceAuraX11::~ThemeServiceAuraX11() {
   views::LinuxUI* linux_ui = views::LinuxUI::instance();
   if (linux_ui)
-    linux_ui->RemoveNativeThemeChangeObserver(this);
+    linux_ui->RemoveSystemThemeChangeObserver(this);
 }
 
-bool ThemeServiceAuraX11::ShouldInitWithNativeTheme() const {
+bool ThemeServiceAuraX11::ShouldInitWithSystemTheme() const {
   return profile()->GetPrefs()->GetBoolean(prefs::kUsesSystemTheme);
 }
 
-void ThemeServiceAuraX11::SetNativeTheme() {
-  SetCustomDefaultTheme(new NativeThemeX11(profile()->GetPrefs()));
+void ThemeServiceAuraX11::UseSystemTheme() {
+  SetCustomDefaultTheme(new SystemThemeX11(profile()->GetPrefs()));
 }
 
 bool ThemeServiceAuraX11::UsingDefaultTheme() const {
-  return ThemeService::UsingDefaultTheme() && !UsingNativeTheme();
+  return ThemeService::UsingDefaultTheme() && !UsingSystemTheme();
 }
 
-bool ThemeServiceAuraX11::UsingNativeTheme() const {
+bool ThemeServiceAuraX11::UsingSystemTheme() const {
   const CustomThemeSupplier* theme_supplier = get_theme_supplier();
   return theme_supplier &&
          theme_supplier->get_theme_type() == CustomThemeSupplier::NATIVE_X11;
 }
 
-void ThemeServiceAuraX11::OnNativeThemeChanged() {
-  if (UsingNativeTheme())
+void ThemeServiceAuraX11::OnSystemThemeChanged() {
+  if (UsingSystemTheme())

[msw, 2014/04/22 18:02:13]

NotifyThemeChanged should be called regardless of this condition, as my
<https://codereview.chromium.org/239093007/> notes, "(Linux Aura didn't update
on changes with "Use Classic Theme", now it does)." You can test this by opting
to use the Classic Theme in about:settings and then changing the system theme to
High Contrast Inverse; the omnibox etc. won't update immediately.

[Evan Stade, 2014/04/22 18:16:06]

Yea, I noticed that, but there's also a difference between a theme changing
(i.e. a different Chrome extension is in use) and a native theme changing.
Dealing with proper updating is a TODO. This CL is just a name change with
minimal behavioral differences.

     NotifyThemeChanged();
 }