Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Side by Side Diff: chrome/browser/extensions/theme_installed_infobar_delegate.cc

Issue 244893004: Improve some naming (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/theme_installed_infobar_delegate.h" 5 #include "chrome/browser/extensions/theme_installed_infobar_delegate.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "chrome/browser/chrome_notification_types.h" 10 #include "chrome/browser/chrome_notification_types.h"
(...skipping 10 matching lines...) Expand all
21 #include "grit/generated_resources.h" 21 #include "grit/generated_resources.h"
22 #include "grit/theme_resources.h" 22 #include "grit/theme_resources.h"
23 #include "ui/base/l10n/l10n_util.h" 23 #include "ui/base/l10n/l10n_util.h"
24 24
25 25
26 // static 26 // static
27 void ThemeInstalledInfoBarDelegate::Create( 27 void ThemeInstalledInfoBarDelegate::Create(
28 const extensions::Extension* new_theme, 28 const extensions::Extension* new_theme,
29 Profile* profile, 29 Profile* profile,
30 const std::string& previous_theme_id, 30 const std::string& previous_theme_id,
31 bool previous_using_native_theme) { 31 bool previous_using_system_theme) {
32 DCHECK(new_theme); 32 DCHECK(new_theme);
33 if (!new_theme->is_theme()) 33 if (!new_theme->is_theme())
34 return; 34 return;
35 35
36 // Create the new infobar. 36 // Create the new infobar.
37 // FindTabbedBrowser() is called with |match_original_profiles| true because a 37 // FindTabbedBrowser() is called with |match_original_profiles| true because a
38 // theme install in either a normal or incognito window for a profile affects 38 // theme install in either a normal or incognito window for a profile affects
39 // all normal and incognito windows for that profile. 39 // all normal and incognito windows for that profile.
40 Browser* browser = 40 Browser* browser =
41 chrome::FindTabbedBrowser(profile, true, chrome::GetActiveDesktop()); 41 chrome::FindTabbedBrowser(profile, true, chrome::GetActiveDesktop());
42 if (!browser) 42 if (!browser)
43 return; 43 return;
44 content::WebContents* web_contents = 44 content::WebContents* web_contents =
45 browser->tab_strip_model()->GetActiveWebContents(); 45 browser->tab_strip_model()->GetActiveWebContents();
46 if (!web_contents) 46 if (!web_contents)
47 return; 47 return;
48 InfoBarService* infobar_service = 48 InfoBarService* infobar_service =
49 InfoBarService::FromWebContents(web_contents); 49 InfoBarService::FromWebContents(web_contents);
50 ThemeService* theme_service = ThemeServiceFactory::GetForProfile(profile); 50 ThemeService* theme_service = ThemeServiceFactory::GetForProfile(profile);
51 scoped_ptr<InfoBar> new_infobar(ConfirmInfoBarDelegate::CreateInfoBar( 51 scoped_ptr<InfoBar> new_infobar(ConfirmInfoBarDelegate::CreateInfoBar(
52 scoped_ptr<ConfirmInfoBarDelegate>(new ThemeInstalledInfoBarDelegate( 52 scoped_ptr<ConfirmInfoBarDelegate>(new ThemeInstalledInfoBarDelegate(
53 profile->GetExtensionService(), theme_service, new_theme, 53 profile->GetExtensionService(), theme_service, new_theme,
54 previous_theme_id, previous_using_native_theme)))); 54 previous_theme_id, previous_using_system_theme))));
55 55
56 // If there's a previous theme infobar, just replace that instead of adding a 56 // If there's a previous theme infobar, just replace that instead of adding a
57 // new one. 57 // new one.
58 for (size_t i = 0; i < infobar_service->infobar_count(); ++i) { 58 for (size_t i = 0; i < infobar_service->infobar_count(); ++i) {
59 InfoBar* old_infobar = infobar_service->infobar_at(i); 59 InfoBar* old_infobar = infobar_service->infobar_at(i);
60 ThemeInstalledInfoBarDelegate* theme_infobar = 60 ThemeInstalledInfoBarDelegate* theme_infobar =
61 old_infobar->delegate()->AsThemePreviewInfobarDelegate(); 61 old_infobar->delegate()->AsThemePreviewInfobarDelegate();
62 if (theme_infobar) { 62 if (theme_infobar) {
63 // If the user installed the same theme twice, ignore the second install 63 // If the user installed the same theme twice, ignore the second install
64 // and keep the first install info bar, so that they can easily undo to 64 // and keep the first install info bar, so that they can easily undo to
65 // get back the previous theme. 65 // get back the previous theme.
66 if (theme_infobar->theme_id_ != new_theme->id()) { 66 if (theme_infobar->theme_id_ != new_theme->id()) {
67 infobar_service->ReplaceInfoBar(old_infobar, new_infobar.Pass()); 67 infobar_service->ReplaceInfoBar(old_infobar, new_infobar.Pass());
68 theme_service->OnInfobarDisplayed(); 68 theme_service->OnInfobarDisplayed();
69 } 69 }
70 return; 70 return;
71 } 71 }
72 } 72 }
73 73
74 // No previous theme infobar, so add this. 74 // No previous theme infobar, so add this.
75 infobar_service->AddInfoBar(new_infobar.Pass()); 75 infobar_service->AddInfoBar(new_infobar.Pass());
76 theme_service->OnInfobarDisplayed(); 76 theme_service->OnInfobarDisplayed();
77 } 77 }
78 78
79 ThemeInstalledInfoBarDelegate::ThemeInstalledInfoBarDelegate( 79 ThemeInstalledInfoBarDelegate::ThemeInstalledInfoBarDelegate(
80 ExtensionService* extension_service, 80 ExtensionService* extension_service,
81 ThemeService* theme_service, 81 ThemeService* theme_service,
82 const extensions::Extension* new_theme, 82 const extensions::Extension* new_theme,
83 const std::string& previous_theme_id, 83 const std::string& previous_theme_id,
84 bool previous_using_native_theme) 84 bool previous_using_system_theme)
85 : ConfirmInfoBarDelegate(), 85 : ConfirmInfoBarDelegate(),
86 extension_service_(extension_service), 86 extension_service_(extension_service),
87 theme_service_(theme_service), 87 theme_service_(theme_service),
88 name_(new_theme->name()), 88 name_(new_theme->name()),
89 theme_id_(new_theme->id()), 89 theme_id_(new_theme->id()),
90 previous_theme_id_(previous_theme_id), 90 previous_theme_id_(previous_theme_id),
91 previous_using_native_theme_(previous_using_native_theme) { 91 previous_using_system_theme_(previous_using_system_theme) {
92 registrar_.Add(this, chrome::NOTIFICATION_BROWSER_THEME_CHANGED, 92 registrar_.Add(this, chrome::NOTIFICATION_BROWSER_THEME_CHANGED,
93 content::Source<ThemeService>(theme_service_)); 93 content::Source<ThemeService>(theme_service_));
94 } 94 }
95 95
96 ThemeInstalledInfoBarDelegate::~ThemeInstalledInfoBarDelegate() { 96 ThemeInstalledInfoBarDelegate::~ThemeInstalledInfoBarDelegate() {
97 // We don't want any notifications while we're running our destructor. 97 // We don't want any notifications while we're running our destructor.
98 registrar_.RemoveAll(); 98 registrar_.RemoveAll();
99 99
100 theme_service_->OnInfobarDestroyed(); 100 theme_service_->OnInfobarDestroyed();
101 } 101 }
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 bool ThemeInstalledInfoBarDelegate::Cancel() { 133 bool ThemeInstalledInfoBarDelegate::Cancel() {
134 if (!previous_theme_id_.empty()) { 134 if (!previous_theme_id_.empty()) {
135 const extensions::Extension* previous_theme = 135 const extensions::Extension* previous_theme =
136 extension_service_->GetExtensionById(previous_theme_id_, true); 136 extension_service_->GetExtensionById(previous_theme_id_, true);
137 if (previous_theme) { 137 if (previous_theme) {
138 theme_service_->SetTheme(previous_theme); 138 theme_service_->SetTheme(previous_theme);
139 return false; // The theme change will close us. 139 return false; // The theme change will close us.
140 } 140 }
141 } 141 }
142 142
143 if (previous_using_native_theme_) 143 if (previous_using_system_theme_)
144 theme_service_->SetNativeTheme(); 144 theme_service_->UseSystemTheme();
145 else 145 else
146 theme_service_->UseDefaultTheme(); 146 theme_service_->UseDefaultTheme();
147 return false; // The theme change will close us. 147 return false; // The theme change will close us.
148 } 148 }
149 149
150 void ThemeInstalledInfoBarDelegate::Observe( 150 void ThemeInstalledInfoBarDelegate::Observe(
151 int type, 151 int type,
152 const content::NotificationSource& source, 152 const content::NotificationSource& source,
153 const content::NotificationDetails& details) { 153 const content::NotificationDetails& details) {
154 DCHECK_EQ(chrome::NOTIFICATION_BROWSER_THEME_CHANGED, type); 154 DCHECK_EQ(chrome::NOTIFICATION_BROWSER_THEME_CHANGED, type);
155 // If the new theme is different from what this info bar is associated with, 155 // If the new theme is different from what this info bar is associated with,
156 // close this info bar since it is no longer relevant. 156 // close this info bar since it is no longer relevant.
157 if (theme_id_ != theme_service_->GetThemeID()) 157 if (theme_id_ != theme_service_->GetThemeID())
158 infobar()->RemoveSelf(); 158 infobar()->RemoveSelf();
159 } 159 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698