Fix separator positioning in app menu dropdown in RTL.

chrome/browser/ui/views/toolbar/app_menu.cc

Index: chrome/browser/ui/views/toolbar/app_menu.cc
diff --git a/chrome/browser/ui/views/toolbar/app_menu.cc b/chrome/browser/ui/views/toolbar/app_menu.cc
index 5547f62ad39a32eb43e95858ee1efe0138f69869..7d4eb63c42d9c82acbaca39e6216a756c0525620 100644
--- a/chrome/browser/ui/views/toolbar/app_menu.cc
+++ b/chrome/browser/ui/views/toolbar/app_menu.cc
@@ -163,7 +163,7 @@ class InMenuButtonBackground : public views::Background {
     gfx::Rect bounds(view->GetLocalBounds());
     if (type_ == LEADING_BORDER) {
       gfx::ScopedRTLFlipCanvas scoped_canvas(
-          canvas, view->width(), view->flip_canvas_on_paint_for_rtl_ui());
+          canvas, view->width(), !view->flip_canvas_on_paint_for_rtl_ui());

[sky, 2016/10/25 16:49:18]

Please add a comment here as it isn't obvious why the ! is needed.

[Peter Kasting, 2016/10/25 17:51:00]

Updated comments for clarity.

       canvas->FillRect(gfx::Rect(0, 0, 1, h),
                        BorderColor(view, views::Button::STATE_NORMAL));
       bounds.Inset(gfx::Insets(0, 1, 0, 0));