Issue 24489002: Remove LINK entries in make_global_settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24489002: Remove LINK entries in make_global_settings. (Closed)

Created:
7 years, 3 months ago by Nico

Modified:
7 years, 2 months ago

Reviewers:
scottmg

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Remove LINK entries in make_global_settings. LINK isn't looked at by the ninja generator, and since gyp https://code.google.com/p/gyp/source/detail?r=1721 both make and ninja default the linker to what's set via CC, which is usually what is desired anyways. Since no bots use make anymore, this shouldn't have an observable effect. Even if the bots were still using make, the default of CC should be make this an almost-noop. BUG=none R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225200

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -8 lines)			Patch
	M	build/common.gypi	View		2 chunks	+0 lines, -8 lines	0 comments	Download

Total messages: 3 (0 generated)

Nico

7 years, 2 months ago (2013-09-25 17:28:23 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r225200 (presubmit successful).