Check switch flag in CancelPermissionRequest

Check switch flag in CancelPermissionRequest

We use a switch flag to guard if we want to reuse PermissionRequestManager on
Android. This CL checks if the flag is enabled in CancelPermissionRequest.

After this we have guarded all places that use PermissionQueueController. When
grouped permission infobars are ready to use, we could enable the flag by default.

BUG=606138
Committed: https://crrev.com/a45bec9b24e74cf372126c155cf3b54c17be83b1
Cr-Commit-Position: refs/heads/master@{#427958}

[lshang, 2016-10-25 06:46:14]

Description was changed from

==========
Check switch flag in CancelPermissionRequest


check

BUG=606138
==========

to

==========
Check switch flag in CancelPermissionRequest

We use a switch flag to guard if we want to reuse PermissionRequestManager on
Android. This CL checks if the flag is enabled in CancelPermissionRequest.

After this we have guarded all places that use PermissionQueueController. When
grouped permission infobars are ready to use, we could enable the flag by
default.

BUG=606138
==========

[lshang, 2016-10-27 02:34:22]

The CQ bit was checked by lshang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 02:34:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lshang, 2016-10-27 02:39:10]

lshang@chromium.org changed reviewers:
+ raymes@chromium.org

[lshang, 2016-10-27 02:39:11]

Hi Raymes, PTAL thanks! This should go with changes in DecidePermission():P

[commit-bot: I haz the power, 2016-10-27 03:46:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 03:46:12]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[raymes, 2016-10-27 04:35:52]

lgtm

https://codereview.chromium.org/2448893002/diff/1/chrome/browser/permissions/...
File chrome/browser/permissions/permission_context_base.cc (right):

https://codereview.chromium.org/2448893002/diff/1/chrome/browser/permissions/...
chrome/browser/permissions/permission_context_base.cc:157: if (cancelling !=
NULL && web_contents != NULL &&
nit: nullptr

[lshang, 2016-10-27 06:45:20]

Thanks Raymes!

https://codereview.chromium.org/2448893002/diff/1/chrome/browser/permissions/...
File chrome/browser/permissions/permission_context_base.cc (right):

https://codereview.chromium.org/2448893002/diff/1/chrome/browser/permissions/...
chrome/browser/permissions/permission_context_base.cc:157: if (cancelling !=
NULL && web_contents != NULL &&
On 2016/10/27 04:35:52, raymes wrote:
> nit: nullptr

Done.

[lshang, 2016-10-27 06:45:25]

The CQ bit was checked by lshang@chromium.org

[lshang, 2016-10-27 06:45:25]

The patchset sent to the CQ was uploaded after l-g-t-m from raymes@chromium.org
Link to the patchset: https://codereview.chromium.org/2448893002/#ps20001
(title: "nullptr")

[commit-bot: I haz the power, 2016-10-27 06:45:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 08:19:21]

Description was changed from

==========
Check switch flag in CancelPermissionRequest

We use a switch flag to guard if we want to reuse PermissionRequestManager on
Android. This CL checks if the flag is enabled in CancelPermissionRequest.

After this we have guarded all places that use PermissionQueueController. When
grouped permission infobars are ready to use, we could enable the flag by
default.

BUG=606138
==========

to

==========
Check switch flag in CancelPermissionRequest

We use a switch flag to guard if we want to reuse PermissionRequestManager on
Android. This CL checks if the flag is enabled in CancelPermissionRequest.

After this we have guarded all places that use PermissionQueueController. When
grouped permission infobars are ready to use, we could enable the flag by
default.

BUG=606138
==========

[commit-bot: I haz the power, 2016-10-27 08:19:22]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-27 08:21:55]

Description was changed from

==========
Check switch flag in CancelPermissionRequest

We use a switch flag to guard if we want to reuse PermissionRequestManager on
Android. This CL checks if the flag is enabled in CancelPermissionRequest.

After this we have guarded all places that use PermissionQueueController. When
grouped permission infobars are ready to use, we could enable the flag by
default.

BUG=606138
==========

to

==========
Check switch flag in CancelPermissionRequest

We use a switch flag to guard if we want to reuse PermissionRequestManager on
Android. This CL checks if the flag is enabled in CancelPermissionRequest.

After this we have guarded all places that use PermissionQueueController. When
grouped permission infobars are ready to use, we could enable the flag by
default.

BUG=606138

Committed: https://crrev.com/a45bec9b24e74cf372126c155cf3b54c17be83b1
Cr-Commit-Position: refs/heads/master@{#427958}
==========

[commit-bot: I haz the power, 2016-10-27 08:21:56]

Patchset 2 (id:??) landed as
https://crrev.com/a45bec9b24e74cf372126c155cf3b54c17be83b1
Cr-Commit-Position: refs/heads/master@{#427958}