Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2448873004: Add convenience getter to extract the location of an AST node. (Closed)

Created:
4 years, 1 month ago by asgerf
Modified:
4 years, 1 month ago
CC:
dart-kernel+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add convenience getter to extract the location of an AST node. TreeNode.location is a getter for use in diagnostics and debugging. It uses parent pointers to find the enclosing file URI and line ending table of the node. If the node has no offset stored, it will use that of the first enclosing parent that has an offset. BUG= R=ahe@google.com, jensj@google.com Committed: https://github.com/dart-lang/kernel/commit/5a40636eef78d5ab1a87fe100ce0fd98bd7f0a22

Patch Set 1 #

Patch Set 2 : Remove unintended changes #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -0 lines) Patch
M lib/ast.dart View 1 5 chunks +62 lines, -0 lines 1 comment Download

Messages

Total messages: 7 (3 generated)
asgerf
4 years, 1 month ago (2016-10-25 14:29:10 UTC) #2
ahe
lgtm https://codereview.chromium.org/2448873004/diff/20001/lib/ast.dart File lib/ast.dart (right): https://codereview.chromium.org/2448873004/diff/20001/lib/ast.dart#newcode3553 lib/ast.dart:3553: /// A tuple with file, line, and column ...
4 years, 1 month ago (2016-10-25 14:43:35 UTC) #4
jensj
lgtm
4 years, 1 month ago (2016-10-26 06:23:52 UTC) #5
asgerf
4 years, 1 month ago (2016-10-31 10:29:43 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
5a40636eef78d5ab1a87fe100ce0fd98bd7f0a22 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698