[DO NOT COMMIT] WorkletThreadHolader

[DO NOT COMMIT] WorkletThreadHolader

This is for https://codereview.chromium.org/2432543002/

[nhiroki, 2016-10-25 03:34:16]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 03:34:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2016-10-25 04:04:03]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 04:04:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2016-10-25 04:04:55]

Description was changed from

==========
[DO NOT COMMIT] WorkletThreadHolader
==========

to

==========
[DO NOT COMMIT] WorkletThreadHolader

This is for https://codereview.chromium.org/2432543002/
==========

[nhiroki, 2016-10-25 04:05:14]

Patchset #1 (id:1) has been deleted

[nhiroki, 2016-10-25 04:05:21]

Patchset #1 (id:20001) has been deleted

[nhiroki, 2016-10-25 04:05:26]

Patchset #1 (id:40001) has been deleted

[commit-bot: I haz the power, 2016-10-25 05:04:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 05:04:07]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[nhiroki, 2016-10-25 09:33:07]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 09:33:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 10:26:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 10:26:46]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nhiroki, 2016-10-25 11:04:36]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 11:04:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 12:41:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 12:41:39]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[hongchan, 2016-10-25 16:34:27]

On 2016/10/25 12:41:39, commit-bot: I haz the power wrote:
> Dry run: Try jobs failed on following builders:
>   linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Thank you, Hiroki-san!

I am learning a lot about 'template design' in the chromium env. The only issue
with this patch is the leak (found by linux_chromium_asan_rel_ng). Hopefully we
can fix this soon as well!

[nhiroki, 2016-10-25 22:42:53]

On 2016/10/25 16:34:27, hongchan wrote:
> On 2016/10/25 12:41:39, commit-bot: I haz the power wrote:
> > Dry run: Try jobs failed on following builders:
> >   linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
> 
> Thank you, Hiroki-san!
> 
> I am learning a lot about 'template design' in the chromium env. The only
issue
> with this patch is the leak (found by linux_chromium_asan_rel_ng). Hopefully
we
> can fix this soon as well!

I also learned a lot about templates while creating this CL :)

[haraken, 2016-10-26 07:41:49]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2016-10-26 07:41:49]

https://codereview.chromium.org/2448863002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/webaudio/AudioWorkletThread.cpp (right):

https://codereview.chromium.org/2448863002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/AudioWorkletThread.cpp:73:
WorkletThreadHolder<AudioWorkletThread>::clearInstance();

Are you sure that this method is called?

As far as I look at the leak log, it looks like WorkletGlobalScope is not
released.

[nhiroki, 2016-10-26 08:10:02]

https://codereview.chromium.org/2448863002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/webaudio/AudioWorkletThread.cpp (right):

https://codereview.chromium.org/2448863002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webaudio/AudioWorkletThread.cpp:73:
WorkletThreadHolder<AudioWorkletThread>::clearInstance();
On 2016/10/26 07:41:49, haraken wrote:
> 
> Are you sure that this method is called?
> 
> As far as I look at the leak log, it looks like WorkletGlobalScope is not
> released.

Good catch! I replied in the original CL:
https://codereview.chromium.org/2432543002/