Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 2448853002: Rename SynchronousCompositorObserver to BrowserFilter (Closed)

Created:
4 years, 1 month ago by boliu
Modified:
4 years, 1 month ago
Reviewers:
sgurun-gerrit only
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, Tobias Sargeant
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename SynchronousCompositorObserver to BrowserFilter SynchronousCompositorFilter is already taken. Pure rename CL. BUG=636164 Committed: https://crrev.com/22557974650f2d3770b691d98990fd7791f133bf Cr-Commit-Position: refs/heads/master@{#427373}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -269 lines) Patch
M content/browser/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/browser/android/synchronous_compositor_browser_filter.h View 4 chunks +8 lines, -9 lines 0 comments Download
A + content/browser/android/synchronous_compositor_browser_filter.cc View 7 chunks +18 lines, -16 lines 0 comments Download
M content/browser/android/synchronous_compositor_host.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/android/synchronous_compositor_host.cc View 4 chunks +4 lines, -4 lines 0 comments Download
D content/browser/android/synchronous_compositor_observer.h View 1 chunk +0 lines, -72 lines 0 comments Download
D content/browser/android/synchronous_compositor_observer.cc View 1 chunk +0 lines, -159 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 3 chunks +4 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
boliu
ptal?
4 years, 1 month ago (2016-10-25 15:05:44 UTC) #3
sgurun-gerrit only
On 2016/10/25 15:05:44, boliu wrote: > ptal? lgtm
4 years, 1 month ago (2016-10-25 15:28:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2448853002/1
4 years, 1 month ago (2016-10-25 15:31:59 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 16:08:55 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 16:14:49 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/22557974650f2d3770b691d98990fd7791f133bf
Cr-Commit-Position: refs/heads/master@{#427373}

Powered by Google App Engine
This is Rietveld 408576698