third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection.html - Issue 2448843003: Throw SyntaxError for non-turn/turns/stun URLs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection.html

Issue 2448843003: Throw SyntaxError for non-turn/turns/stun URLs (Closed)

Patch Set: split valid and scheme checks Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-expected.txt » ('j') | third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection.html

diff --git a/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection.html b/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection.html

index f0e5a87c86b199ed5780da63c715949036b62213..386214c353f0a6339800051d7da3b4910963c231 100644

--- a/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection.html

+++ b/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection.html

@@ -27,6 +27,7 @@ shouldThrow("new RTCPeerConnection({iceServers:true});");

shouldThrow("new RTCPeerConnection({iceServers:[1, 2, 3]});");

shouldThrow("new RTCPeerConnection({iceServers:[{}]});");

shouldThrow("new RTCPeerConnection({iceServers:[{url:'foo'}]});");

+shouldThrow("new RTCPeerConnection({iceServers:[{urls:'unsupported:scheme'}]});");

shouldThrow("new RTCPeerConnection({iceServers:[{urls:[1, 'turn:foo.com']}]});");

shouldNotThrow("new RTCPeerConnection({iceServers:[], iceTransports:'none'});");