Throw SyntaxError for non-turn/turns/stun URLs

third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 288 matching lines @@
       } else {
         exceptionState.throwTypeError("Malformed RTCIceServer");
         return WebRTCConfiguration();
       }
 
       String username = iceServer.username();
       String credential = iceServer.credential();
 
       for (const String& urlString : urlStrings) {
         KURL url(KURL(), urlString);
-        if (!url.isValid() ||
-            !(url.protocolIs("turn") || url.protocolIs("turns") ||
+        if (!url.isValid()) {
+          exceptionState.throwDOMException(
+              SyntaxError, "'" + urlString + "' is not a valid URL.");
+          return WebRTCConfiguration();
+        }
+        if (!(url.protocolIs("turn") || url.protocolIs("turns") ||
               url.protocolIs("stun"))) {
-          exceptionState.throwTypeError("Malformed URL");
+          exceptionState.throwDOMException(
+              SyntaxError, "'" + url.protocol() +

[foolip, 2016/10/27 13:34:38]

This really isn't a SyntaxError, do we care? I don't care enough to ask to have
the spec changed :)

[hta - Chromium, 2016/11/08 12:12:30]

Neither do I :-) It's an illegal parameter, as long as it fails consistently, it
seems good to me.

+                               "' is not one of the supported URL schemes "
+                               "'stun', 'turn' or 'turns'.");
           return WebRTCConfiguration();
         }
         iceServers.append(WebRTCIceServer{url, username, credential});
       }
     }
     webConfiguration.iceServers = iceServers;
   }
 
   if (configuration.hasCertificates()) {
     const HeapVector<Member<RTCCertificate>>& certificates =
@@ skipping 1142 matching lines @@
 DEFINE_TRACE(RTCPeerConnection) {
   visitor->trace(m_localStreams);
   visitor->trace(m_remoteStreams);
   visitor->trace(m_dispatchScheduledEventRunner);
   visitor->trace(m_scheduledEvents);
   EventTargetWithInlineData::trace(visitor);
   ActiveDOMObject::trace(visitor);
 }
 
 }  // namespace blink