Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2448833006: arc: Make ActivityName.activity_name nullable. (Closed)

Created:
4 years, 1 month ago by Daniel Erat
Modified:
4 years, 1 month ago
Reviewers:
Yusuke Sato, dcheng, kinaba
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, viettrungluu+watch_chromium.org, hidehiko+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, lhchavez+watch_chromium.org, darin (slow to review), qsr+mojo_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Make ActivityName.activity_name nullable. Make the ActivityName struct's activity_name field nullable so that IntentHelperInstance.HandleIntent can be used to launch an arbitrary applicable activity within a given package. BUG=659802 Committed: https://crrev.com/6a13c43acff6124abf2f0816492d348bce8b16cf Cr-Commit-Position: refs/heads/master@{#427879}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/arc/common/intent_helper.mojom View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
Daniel Erat
4 years, 1 month ago (2016-10-26 22:53:17 UTC) #2
Daniel Erat
(nothing on the chrome side passes a null value currently)
4 years, 1 month ago (2016-10-26 22:55:26 UTC) #3
Yusuke Sato
lgtm
4 years, 1 month ago (2016-10-26 23:02:10 UTC) #6
dcheng
lgtm
4 years, 1 month ago (2016-10-26 23:28:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2448833006/1
4 years, 1 month ago (2016-10-26 23:32:27 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 23:37:58 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 23:42:19 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a13c43acff6124abf2f0816492d348bce8b16cf
Cr-Commit-Position: refs/heads/master@{#427879}

Powered by Google App Engine
This is Rietveld 408576698