Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2448833004: [wasm] Fix binary search for asm.js offsets (Closed)

Created:
4 years, 1 month ago by Clemens Hammacher
Modified:
4 years, 1 month ago
Reviewers:
titzer, ahaas
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Fix binary search for asm.js offsets And add a test case for more than one entry ;) R=titzer@chromium.org,ahaas@chromium.org Committed: https://crrev.com/5452f97ede574833c24da7ef4d8e3f286bb32f7c Cr-Commit-Position: refs/heads/master@{#40553}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -11 lines) Patch
M src/wasm/wasm-debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/asm-wasm-stack.js View 5 chunks +17 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Clemens Hammacher
4 years, 1 month ago (2016-10-25 08:47:59 UTC) #3
titzer
On 2016/10/25 08:47:59, Clemens Hammacher wrote: lgtm
4 years, 1 month ago (2016-10-25 08:51:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2448833004/1
4 years, 1 month ago (2016-10-25 08:58:42 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 09:00:45 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:12:09 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5452f97ede574833c24da7ef4d8e3f286bb32f7c
Cr-Commit-Position: refs/heads/master@{#40553}

Powered by Google App Engine
This is Rietveld 408576698