Sandbox should prevent 'execCommand("print", ...)'.

Sandbox should prevent 'execCommand("print", ...)'.

Unless 'allow-modals' is present, 'sandbox' should prevent modal dialogs,
including the print dialog popped up from 'execCommand("print", ...)'.
The existing code doesn't handle this case; this patch moves the sandbox
check up to 'ChromeClient::print()', which handles both 'print()' and
'execCommand("print", ...'.

BUG=658985
R=jochen@chromium.org

Committed: https://crrev.com/6a616686e564d5cac7d25b61070b5031a818df8d
Cr-Commit-Position: refs/heads/master@{#427664}

[Mike West, 2016-10-25 07:59:04]

The CQ bit was checked by mkwst@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 07:59:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mike West, 2016-10-25 09:43:53]

WDYT, Jochen?

[commit-bot: I haz the power, 2016-10-25 09:53:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 09:53:18]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-10-26 08:22:42]

lgtm

[Mike West, 2016-10-26 08:24:42]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2016-10-26 08:24:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 10:48:16]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-26 10:50:01]

Description was changed from

==========
Sandbox should prevent 'execCommand("print", ...)'.

Unless 'allow-modals' is present, 'sandbox' should prevent modal dialogs,
including the print dialog popped up from 'execCommand("print", ...)'.
The existing code doesn't handle this case; this patch moves the sandbox
check up to 'ChromeClient::print()', which handles both 'print()' and
'execCommand("print", ...'.

BUG=658985
R=jochen@chromium.org
==========

to

==========
Sandbox should prevent 'execCommand("print", ...)'.

Unless 'allow-modals' is present, 'sandbox' should prevent modal dialogs,
including the print dialog popped up from 'execCommand("print", ...)'.
The existing code doesn't handle this case; this patch moves the sandbox
check up to 'ChromeClient::print()', which handles both 'print()' and
'execCommand("print", ...'.

BUG=658985
R=jochen@chromium.org

Committed: https://crrev.com/6a616686e564d5cac7d25b61070b5031a818df8d
Cr-Commit-Position: refs/heads/master@{#427664}
==========

[commit-bot: I haz the power, 2016-10-26 10:50:02]

Patchset 1 (id:??) landed as
https://crrev.com/6a616686e564d5cac7d25b61070b5031a818df8d
Cr-Commit-Position: refs/heads/master@{#427664}