Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 244883005: Mojo: Update/add README.md files. (Closed)

Created:
6 years, 8 months ago by viettrungluu
Modified:
6 years, 8 months ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: Update/add README.md files. Also move async_waiter.h from c/system to c/environment. (It's not a part of the system API per se; instead, it defines stuff that the app must provide to, e.g., the gles2 subsystem. This move makes the organization of the C subdirectory more closely parallel the C++ subdirectory.) R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265176

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -97 lines) Patch
M mojo/bindings/js/waiting_callback.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/environment/default_async_waiter_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo_public.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/README.md View 1 chunk +28 lines, -47 lines 0 comments Download
A mojo/public/c/README.md View 1 chunk +45 lines, -0 lines 0 comments Download
A + mojo/public/c/environment/async_waiter.h View 2 chunks +3 lines, -3 lines 0 comments Download
A mojo/public/c/gles2/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/public/c/gles2/gles2.h View 1 chunk +1 line, -1 line 0 comments Download
D mojo/public/c/system/async_waiter.h View 1 chunk +0 lines, -40 lines 0 comments Download
M mojo/public/c/system/tests/core_unittest_pure_c.c View 1 chunk +1 line, -1 line 0 comments Download
A mojo/public/cpp/README.md View 1 chunk +71 lines, -0 lines 0 comments Download
A mojo/public/cpp/environment/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/public/cpp/environment/default_async_waiter.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/gles2/gles2_private.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
viettrungluu
6 years, 8 months ago (2014-04-22 00:43:32 UTC) #1
darin (slow to review)
Nice change. LGTM
6 years, 8 months ago (2014-04-22 03:51:51 UTC) #2
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 8 months ago (2014-04-22 04:00:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/244883005/1
6 years, 8 months ago (2014-04-22 04:00:23 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-22 04:55:53 UTC) #5
Message was sent while issue was closed. 
Change committed as 265176

Powered by Google App Engine
This is Rietveld 408576698