Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 2448823002: [ios] Adds the LogoAnimationController protocol. (Closed)

Created:
4 years, 1 month ago by rohitrao (ping after 24h)
Modified:
4 years, 1 month ago
Reviewers:
kkhorimoto
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Adds the LogoAnimationController protocol. BUG=656617 Committed: https://crrev.com/3bfc33b5c3c4d405709f311a76c1646fcb0ba6dd Cr-Commit-Position: refs/heads/master@{#427329}

Patch Set 1 #

Patch Set 2 : GN. #

Patch Set 3 : Drop Default. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -0 lines) Patch
M ios/public/provider/chrome/browser/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
A ios/public/provider/chrome/browser/voice/logo_animation_controller.h View 1 2 1 chunk +64 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
rohitrao (ping after 24h)
4 years, 1 month ago (2016-10-25 02:23:13 UTC) #2
kkhorimoto
lgtm
4 years, 1 month ago (2016-10-25 02:54:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2448823002/20001
4 years, 1 month ago (2016-10-25 11:41:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2448823002/40001
4 years, 1 month ago (2016-10-25 12:54:47 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-10-25 12:58:24 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 13:00:38 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3bfc33b5c3c4d405709f311a76c1646fcb0ba6dd
Cr-Commit-Position: refs/heads/master@{#427329}

Powered by Google App Engine
This is Rietveld 408576698