Issue 24488002: Merge 224232 "Do not rewrite AltGr Key as Alt+Ctrl"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24488002: Merge 224232 "Do not rewrite AltGr Key as Alt+Ctrl" (Closed)

Created:
7 years, 3 months ago by Seigo Nonaka

Modified:
7 years, 3 months ago

Reviewers:
Seigo Nonaka

CC:
chromium-reviews, jbauman+watch_chromium.org, James Su, nkostylev+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, piman+watch_chromium.org, danakj+watch_chromium.org, miu+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1599/src/

Visibility:
Public.

More Reviews

Description

Merge 224232 "Do not rewrite AltGr Key as Alt+Ctrl" > Do not rewrite AltGr Key as Alt+Ctrl > > This is partial revert of http://crrev.com/215376 > It turned out that this breaks browser accelerator triggered with Ctrl+Alt like spoken feedback or opening secure shell. > > And also that CL changes AltGr behavior to meet as Windows but some we application already works on current behaviors. As the result some application including Google Docs or Secure Shell breaks. > > So rewriting to Alt+Ctrl is no longer feasible conversion. > > BUG=253365, 288573, 287338 > TEST=None > > Review URL: https://chromiumcodereview.appspot.com/23890039 TBR=nona@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225114

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -198 lines)			Patch
D	chrome/browser/chromeos/input_method/keyboard_browsertest.cc	View	1 chunk	+0 lines, -96 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	chrome/test/data/textinput/keyevent_logging.html	View	1 chunk	+0 lines, -70 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_aura.cc	View	1 chunk	+0 lines, -26 lines	0 comments	Download
M	content/browser/renderer_host/ui_events_helper.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r225114.

Expand Messages | Collapse Messages