Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: ios/testing/wait_util.mm

Issue 2448753002: Refactor wait_util so it isn't coupled to EarlGrey. (Closed)
Patch Set: cleanup Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/testing/wait_util.mm
diff --git a/ios/testing/earl_grey/wait_util.mm b/ios/testing/wait_util.mm
similarity index 55%
copy from ios/testing/earl_grey/wait_util.mm
copy to ios/testing/wait_util.mm
index e86ea432af5acf3c381c82d41b2196bccf22f046..0bcdb2330ad00d9ab47fce7c8dceaf775abc6f4e 100644
--- a/ios/testing/earl_grey/wait_util.mm
+++ b/ios/testing/wait_util.mm
@@ -2,9 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "ios/testing/earl_grey/wait_util.h"
-
-#import <EarlGrey/EarlGrey.h>
+#include "ios/testing/wait_util.h"
Eugene But (OOO till 7-30) 2016/10/25 14:43:39 s/include/import
baxley 2016/10/25 18:50:05 Done.
#include "base/test/ios/wait_util.h"
@@ -15,20 +13,16 @@ const NSTimeInterval kWaitForJSCompletionTimeout = 2.0;
const NSTimeInterval kWaitForUIElementTimeout = 4.0;
const NSTimeInterval kWaitForDownloadTimeout = 10.0;
-void WaitUntilCondition(NSTimeInterval timeout,
- NSString* timeoutDescription,
- bool (^condition)(void)) {
+bool WaitUntilConditionOrTimeout(NSTimeInterval timeout,
+ bool (^condition)(void)) {
NSDate* deadline = [NSDate dateWithTimeIntervalSinceNow:timeout];
- while (!condition() &&
- [[NSDate date] compare:deadline] != NSOrderedDescending) {
+ bool success = condition();
+ while (!success && [[NSDate date] compare:deadline] != NSOrderedDescending) {
base::test::ios::SpinRunLoopWithMaxDelay(
base::TimeDelta::FromSecondsD(testing::kSpinDelaySeconds));
+ success = condition();
}
- GREYAssert(condition(), timeoutDescription);
-}
-
-void WaitUntilCondition(NSTimeInterval timeout, bool (^condition)(void)) {
- WaitUntilCondition(timeout, @"Timeout waiting for condition.", condition);
+ return success;
}
} // namespace testing

Powered by Google App Engine
This is Rietveld 408576698