Refactor wait_util so it isn't coupled to EarlGrey.

ios/web/public/test/earl_grey/web_view_matchers.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/web/public/test/earl_grey/web_view_matchers.h"
 
 #import <WebKit/WebKit.h>
 
 #include "base/mac/bind_objc_block.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/ios/wait_util.h"
 #include "base/values.h"
-#include "ios/testing/earl_grey/wait_util.h"
+#include "ios/testing/wait_util.h"
 #import "ios/web/public/test/web_view_interaction_test_util.h"
 
 using web::test::ExecuteJavaScript;
 
 namespace {
 
 // Script that returns document.body as a string.
 char kGetDocumentBodyJavaScript[] =
     "document.body ? document.body.textContent : null";
 // Script that tests presence of css selector.
@@ skipping 13 matching lines @@
     [description appendText:@"web view in web state"];
   };
 
   return [[[GREYElementMatcherBlock alloc] initWithMatchesBlock:matches
                                                descriptionBlock:describe]
       autorelease];
 }
 
 id<GREYMatcher> webViewContainingText(std::string text, WebState* web_state) {
   MatchesBlock matches = ^BOOL(WKWebView*) {
-    __block BOOL did_succeed = NO;
-    NSDate* deadline =
-        [NSDate dateWithTimeIntervalSinceNow:testing::kWaitForUIElementTimeout];
-    while (([[NSDate date] compare:deadline] != NSOrderedDescending) &&
-           !did_succeed) {
-      std::unique_ptr<base::Value> value =
-          ExecuteJavaScript(web_state, kGetDocumentBodyJavaScript);
-      std::string body;
-      if (value && value->GetAsString(&body)) {
-        did_succeed = body.find(text) != std::string::npos;
-      }
-      base::test::ios::SpinRunLoopWithMaxDelay(
-          base::TimeDelta::FromSecondsD(testing::kSpinDelaySeconds));
-    }
-    return did_succeed;
+    return testing::WaitUntilConditionOrTimeout(
+        testing::kWaitForUIElementTimeout, ^{
+          std::unique_ptr<base::Value> value =
+              ExecuteJavaScript(web_state, kGetDocumentBodyJavaScript);
+          std::string body;
+          if (value && value->GetAsString(&body)) {
+            return body.find(text) != std::string::npos;
+          }
+          return false;
+        });
   };
 
   DescribeToBlock describe = ^(id<GREYDescription> description) {
     [description appendText:@"web view containing "];
     [description appendText:base::SysUTF8ToNSString(text)];
   };
 
   return grey_allOf(webViewInWebState(web_state),
                     [[[GREYElementMatcherBlock alloc]
                         initWithMatchesBlock:matches
                             descriptionBlock:describe] autorelease],
                     nil);
 }
 
 id<GREYMatcher> webViewContainingBlockedImage(std::string image_id,
                                               CGSize expected_size,
                                               WebState* web_state) {
   MatchesBlock matches = ^BOOL(WKWebView*) {
-    __block BOOL did_succeed = NO;
-    NSDate* deadline =
-        [NSDate dateWithTimeIntervalSinceNow:testing::kWaitForUIElementTimeout];
-    while (([[NSDate date] compare:deadline] != NSOrderedDescending) &&
-           !did_succeed) {
-      NSString* const kGetElementAttributesScript = [NSString
-          stringWithFormat:@"var image = document.getElementById('%@');"
-                           @"var imageHeight = image.height;"
-                           @"var imageWidth = image.width;"
-                           @"JSON.stringify({"
-                           @"  height:imageHeight,"
-                           @"  width:imageWidth"
-                           @"});",
-                           base::SysUTF8ToNSString(image_id)];
-      std::unique_ptr<base::Value> value = ExecuteJavaScript(
-          web_state, base::SysNSStringToUTF8(kGetElementAttributesScript));
-      std::string result;
-      if (value && value->GetAsString(&result)) {
-        NSString* evaluation_result = base::SysUTF8ToNSString(result);
-        NSData* image_attributes_as_data =
-            [evaluation_result dataUsingEncoding:NSUTF8StringEncoding];
-        NSDictionary* image_attributes =
-            [NSJSONSerialization JSONObjectWithData:image_attributes_as_data
-                                            options:0
-                                              error:nil];
-        CGFloat height = [image_attributes[@"height"] floatValue];
-        CGFloat width = [image_attributes[@"width"] floatValue];
-        did_succeed =
-            (height < expected_size.height && width < expected_size.width);
-      }
-      base::test::ios::SpinRunLoopWithMaxDelay(
-          base::TimeDelta::FromSecondsD(testing::kSpinDelaySeconds));
-    }
-    return did_succeed;
+    return testing::WaitUntilConditionOrTimeout(
+        testing::kWaitForUIElementTimeout, ^{
+          NSString* const kGetElementAttributesScript = [NSString
+              stringWithFormat:@"var image = document.getElementById('%@');"
+                               @"var imageHeight = image.height;"
+                               @"var imageWidth = image.width;"
+                               @"JSON.stringify({"
+                               @"  height:imageHeight,"
+                               @"  width:imageWidth"
+                               @"});",
+                               base::SysUTF8ToNSString(image_id)];
+          std::unique_ptr<base::Value> value = ExecuteJavaScript(
+              web_state, base::SysNSStringToUTF8(kGetElementAttributesScript));
+          std::string result;
+          if (value && value->GetAsString(&result)) {
+            NSString* evaluation_result = base::SysUTF8ToNSString(result);
+            NSData* image_attributes_as_data =
+                [evaluation_result dataUsingEncoding:NSUTF8StringEncoding];
+            NSDictionary* image_attributes =
+                [NSJSONSerialization JSONObjectWithData:image_attributes_as_data
+                                                options:0
+                                                  error:nil];
+            CGFloat height = [image_attributes[@"height"] floatValue];
+            CGFloat width = [image_attributes[@"width"] floatValue];
+            return (height < expected_size.height &&
+                    width < expected_size.width);
+          }
+          return false;
+        });
   };
 
   DescribeToBlock describe = ^(id<GREYDescription> description) {
     [description appendText:@"web view blocking resource with id "];
     [description appendText:base::SysUTF8ToNSString(image_id)];
   };
 
   return grey_allOf(webViewInWebState(web_state),
                     [[[GREYElementMatcherBlock alloc]
                         initWithMatchesBlock:matches
                             descriptionBlock:describe] autorelease],
                     nil);
 }
 
 id<GREYMatcher> webViewCssSelector(std::string selector, WebState* web_state) {
   MatchesBlock matches = ^BOOL(WKWebView*) {
     std::string script = base::StringPrintf(kTestCssSelectorJavaScriptTemplate,
                                             selector.c_str());
-    __block bool did_succeed = false;
-    NSDate* deadline =
-        [NSDate dateWithTimeIntervalSinceNow:testing::kWaitForUIElementTimeout];
-    while (([[NSDate date] compare:deadline] != NSOrderedDescending) &&
-           !did_succeed) {
-      std::unique_ptr<base::Value> value = ExecuteJavaScript(web_state, script);
-      if (value)
-        value->GetAsBoolean(&did_succeed);
-      base::test::ios::SpinRunLoopWithMaxDelay(
-          base::TimeDelta::FromSecondsD(testing::kSpinDelaySeconds));
-    }
-    return did_succeed;
+    return testing::WaitUntilConditionOrTimeout(
+        testing::kWaitForUIElementTimeout, ^{
+          bool did_succeed = false;
+          std::unique_ptr<base::Value> value =
+              ExecuteJavaScript(web_state, script);
+          if (value) {
+            value->GetAsBoolean(&did_succeed);
+          }
+          return did_succeed;
+        });
   };
 
   DescribeToBlock describe = ^(id<GREYDescription> description) {
     [description appendText:@"web view selector "];
     [description appendText:base::SysUTF8ToNSString(selector)];
   };
 
   return grey_allOf(webViewInWebState(web_state),
                     [[[GREYElementMatcherBlock alloc]
                         initWithMatchesBlock:matches
@@ skipping 11 matching lines @@
   DescribeToBlock describe = ^(id<GREYDescription> description) {
     [description appendText:@"web view scroll view"];
   };
 
   return [[[GREYElementMatcherBlock alloc] initWithMatchesBlock:matches
                                                descriptionBlock:describe]
       autorelease];
 }
 
 }  // namespace web