bluetooth: Add Device connection logic and accompanying user interface.

chrome/browser/resources/bluetooth_internals/device_table.js

Index: chrome/browser/resources/bluetooth_internals/device_table.js
diff --git a/chrome/browser/resources/bluetooth_internals/device_table.js b/chrome/browser/resources/bluetooth_internals/device_table.js
index c4ed60b58b622de67c6cec0f9016e9bce6c27ac9..e10c998831c6c5a3c69c9d0cf618db11fa5f90ac 100644
--- a/chrome/browser/resources/bluetooth_internals/device_table.js
+++ b/chrome/browser/resources/bluetooth_internals/device_table.js
@@ -7,9 +7,20 @@
  */
 
 cr.define('device_table', function() {
+  var COLUMNS = {
+    NAME: 0,
+    ADDRESS: 1,
+    RSSI: 2,
+    SERVICES: 3,
+    CONNECTION_STATE: 4,
+    INSPECT_BUTTON: 5,
+    CONNECTION_ERROR: 6,
+  };
+
   /**
    * A table that lists the devices and responds to changes in the given
-   *     DeviceCollection.
+   * DeviceCollection. Fires events for inspection requests from listed
+   * devices.
    * @constructor
    * @extends {HTMLTableElement}
    */
@@ -55,16 +66,30 @@ cr.define('device_table', function() {
     /**
      * Updates table row on change event of the device collection.
      * @private
-     * @param {!CustomEvent} event
+     * @param {!Event} event
      */
     handleChange_: function(event) {
       this.updateRow_(this.devices_.item(event.index), event.index);
     },
 
     /**
+     * Fires a inspect pressed event for the row |index|.
+     * @private
+     * @param {number} index
+     */
+    handleInspectBtn_: function(index) {
+      var event = new CustomEvent('inspectpressed', {
+        detail: {
+          address: this.devices_.item(index).address,
+        }
+      });
+      this.dispatchEvent(event);
+    },
+
+    /**
      * Updates table row on splice event of the device collection.
      * @private
-     * @param {!CustomEvent} event
+     * @param {!Event} event
      */
     handleSplice_: function(event) {
       event.removed.forEach(function() {
@@ -79,17 +104,30 @@ cr.define('device_table', function() {
     /**
      * Inserts a new row at |index| and updates it with info from |device|.
      * @private
-     * @param {!device_collection.Device} device
+     * @param {!interfaces.BluetoothDevice.DeviceInfo} device
      * @param {?number} index
      */
     insertRow_: function(device, index) {
       var row = this.body_.insertRow(index);
-      row.id = device.info.address;
+      row.id = device.address;
 
       for (var i = 0; i < this.headers_.length; i++) {
         row.insertCell();
       }
 
+      // Make two extra cells for the inspect button and connect errors.
+      var inspectCell = row.insertCell();
+
+      // TODO(crbug.com/663830): Replace connection error column with better
+      // notification system.
+      var connectErrorCell = row.insertCell();
+
+      var inspectButton = document.createElement('button');
+      inspectCell.appendChild(inspectButton);
+      inspectButton.addEventListener('click', function() {
+        this.handleInspectBtn_(row.sectionRowIndex);
+      }.bind(this));
+
       this.updateRow_(device, row.sectionRowIndex);
     },
 
@@ -111,7 +149,7 @@ cr.define('device_table', function() {
     /**
      * Updates the row at |index| with the info from |device|.
      * @private
-     * @param {!device_collection.Device} device
+     * @param {!interfaces.BluetoothDevice.DeviceInfo} device
      * @param {number} index
      */
     updateRow_: function(device, index) {
@@ -120,20 +158,44 @@ cr.define('device_table', function() {
 
       row.classList.toggle('removed', device.removed);
 
+      var inspectButton = row.cells[COLUMNS.INSPECT_BUTTON].children[0];
+      inspectButton.disabled = false;
+      switch (device.connectionStatus) {
+        case 'disconnected':
+          inspectButton.textContent = 'Inspect';
+          break;
+        case 'connected':
+          inspectButton.textContent = 'Forget';
+          break;
+        case 'connecting':
+          inspectButton.disabled = true;
+          break;
+        default: assert('case not handled');
+      }
+
+      // TODO(crbug.com/663830): Replace connection error column with better
+      // notification system.
+      var connectErrorCell = row.cells[COLUMNS.CONNECTION_ERROR];
+      connectErrorCell.textContent = device.connectionMessage;
+
       // Update the properties based on the header field path.
       for (var i = 0; i < this.headers_.length; i++) {
         var header = this.headers_[i];
         var propName = header.dataset.field;
 
         var parts = propName.split('.');
-        var obj = device.info;
+        var obj = device;
         while (obj != null && parts.length > 0) {
           var part = parts.shift();
           obj = obj[part];
         }
 
+        if (propName == 'is_gatt_connected') {
+          obj ? obj = 'Connected' : obj = 'Not Connected';

[dpapad, 2016/11/10 19:05:03]

This usage of ternary operator is a bit odd
boolean ? foo=a : foo=b;

How about changing to
foo = boolean ? a : b;

[mbrunson, 2016/11/10 22:02:22]

Done.

+        }
+
         var cell = row.cells[i];
-        cell.textContent = obj || 'Unknown';
+        cell.textContent = (obj == null || obj == undefined) ? 'Unknown' : obj;

[dpapad, 2016/11/10 19:05:03]

No need to check both for undefined and null, given that you are using the '=='
operator (instead of '===').

var a = null;
a == undefined; // true
a == null; // true;

var b = null;
b == undefined; // true
b == null; // true;

But besides just checking for one of null,undefined, you can simplify even more.

cell.textContent = obj || 'Unknown';

[mbrunson, 2016/11/10 22:02:22]

Ah true. I forgot about the '=='/'===' thing with null. I'll do that then.

Empty string and zero are falsy, so I don't think I want it to show 'Unknown' if
it's a value that is actually supposed to be 0 or ''.

         cell.dataset.label = header.textContent;
       }
     },