bluetooth: Add Device connection logic and accompanying user interface.

chrome/browser/resources/bluetooth_internals/device_collection.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * Javascript for DeviceCollection, served from
  *     chrome://bluetooth-internals/.
  */
 
 cr.define('device_collection', function() {
@@ skipping 28 matching lines @@
      * Adds or updates a Device with new DeviceInfo.
      * @param {!interfaces.BluetoothDevice.DeviceInfo} deviceInfo
      */
     addOrUpdate: function(deviceInfo) {
       var oldDevice = this.getByAddress(deviceInfo.address);
       if (oldDevice) {
         // Update rssi if it's valid
         var rssi = (deviceInfo.rssi && deviceInfo.rssi.value) ||
             (oldDevice.info.rssi && oldDevice.info.rssi.value);
 
-        oldDevice.info = deviceInfo;
+        Object.assign(oldDevice.info, deviceInfo);
         oldDevice.info.rssi = { value: rssi };
         oldDevice.removed = false;
 
         this.updateIndex(this.indexOf(oldDevice));
       } else {
         this.push(new Device(deviceInfo));
       }
     },
 
     /**
      * Marks the Device as removed.
      * @param {!interfaces.bluetoothDevice.DeviceInfo} deviceInfo
      */
     remove: function(deviceInfo) {
       var device = this.getByAddress(deviceInfo.address);
       assert(device, 'Device does not exist.');
+
       device.removed = true;
+      device.proxy = null;
       this.updateIndex(this.indexOf(device));
-    }
+    },
+
+    /**
+     *
+     */
+    updateConnectionStatus: function(index, optional_error) {

[ortuno, 2016/11/09 03:24:03]

I would use the address instead. If I understand correctly the location of the
device in the array could have changed during the connection.

[mbrunson, 2016/11/09 23:39:37]

Done.

+      var message = (optional_error && optional_error.message) || '';

[ortuno, 2016/11/09 03:24:03]

I would save the information in the device object and just call
this.updateIndex(this.indexOf(device));

[mbrunson, 2016/11/09 23:39:37]

Done.

+      var event = new CustomEvent('connectstatus', {
+        detail: {
+          index: index,
+          message: message,
+        }
+      });
+      this.dispatchEvent(event);
+    },
   };
 
   /*
    * Data model for a cached device.
    * @constructor
    * @param {!interfaces.BluetoothDevice.DeviceInfo} info
    */
   var Device = function(info) {
     this.info = info;
     this.removed = false;
   };
 
+  Device.prototype = {

[ortuno, 2016/11/09 03:24:03]

Before this patch this class used to only hold information about the device so
it made sense for it to be owned by DeviceCollection. But now that we are
exposing functions that are not going to be used by this class we should rethink
its ownership. So my question to you is: How will DeviceDetailsView going to
interact with this? 

My proposal would be to:
1. Turn Device into DeviceInfo and it would be basically be a struct i.e. no
functions and it will only be owned by DeviceCollection (DeviceTable will still
access it but only to retrieve information from it).
2. Have bluetooth_internals (and in the future DeviceDetailsView) manage the
connection process and hold on to the proxy.

// bluetooth_internals.js

let deviceAddressToProxy = new Map();

deviceTable.subscribe('explorepressed', (event) => {
  var address = event.detail.address;
  var proxy = deviceAddressToProxy.get(address);
  if (proxy !== undefined) {
    // Device is already connected, so we disconnect.
    proxy.disconnect();
    deviceAddressToProxy.delete(address);
    devices.updateConnectionStatus(address, 'disconnected');
  } else {
    devices.updateConnectionStatus(address, 'connecting');
    adapterBroker.connectToDevice(address)
      .then(proxy => {
        if (devices.getByAddress(address) === undefined) {
          // Device no longer in list so drop the connection.
          proxy.disconnect();
          return;
        }
        deviceAddressToProxy.set(address, proxy);
        devices.updateConnectionStatus(address, 'connected');
      }).catch(error => {
        // Show toast saying the connection has failed.
        device.updateConnectionStatus(address, 'disconnected');
      });
  }
});

[mbrunson, 2016/11/09 23:39:37]

Hmm ok. So in the final design, DeviceDetailsView would create the connection
and hold the proxy. So, each DeviceDetailsView has its own proxy that it
manages. That makes sense. Done.

+    /**
+     * Creates a connection to this device and updates the service list.
+     * @return {Promise} rejects if connection failed, resolves otherwise.
+     */
+    connect: function() {
+      return adapter_broker.getAdapterBroker().then(function(broker) {
+        return broker.connectToDevice(this.info.address);
+      }.bind(this)).then(function(response) {
+        this.proxy = response.device;
+      }.bind(this));
+    },
+
+    /**
+     * Disconnects the device and removes the Device interface proxy.
+     */
+    disconnect: function() {
+      if (this.proxy) {
+        this.proxy.disconnect();
+        this.proxy = null;
+      }
+    },
+
+    getServices: function() {
+      return this.proxy.getServices().then(function(response) {
+        this.info.services = response.services;
+        return this.info.services;
+      }.bind(this));
+    }
+  };
+
   return {
     Device: Device,
     DeviceCollection: DeviceCollection,
   };
 });