bluetooth: Add Device connection logic and accompanying user interface.

device/bluetooth/adapter.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 #include <utility>
 #include <vector>
 
 #include "device/bluetooth/adapter.h"
 #include "device/bluetooth/device.h"
@@ skipping 16 matching lines @@
   adapter_info->address = adapter_->GetAddress();
   adapter_info->name = adapter_->GetName();
   adapter_info->initialized = adapter_->IsInitialized();
   adapter_info->present = adapter_->IsPresent();
   adapter_info->powered = adapter_->IsPowered();
   adapter_info->discoverable = adapter_->IsDiscoverable();
   adapter_info->discovering = adapter_->IsDiscovering();
   callback.Run(std::move(adapter_info));
 }
 
-void Adapter::GetDevice(const std::string& address,
-                        const GetDeviceCallback& callback) {
-  mojom::DevicePtr device_ptr;
-  mojo::MakeStrongBinding(base::MakeUnique<Device>(address, adapter_),
-                          mojo::GetProxy(&device_ptr));
-  callback.Run(std::move(device_ptr));
+void Adapter::ConnectToDevice(const std::string& address,
+                              const ConnectToDeviceCallback& callback) {
+  device::BluetoothDevice* device = adapter_->GetDevice(address);
+  if (device) {

[ortuno, 2016/10/25 10:42:09]

nit: To avoid indenting lines:

if (!condition) {
  // run callback and return.
}

// success case

[mbrunson, 2016/10/25 20:03:03]

Done.

+    device->CreateGattConnection(
+        base::Bind(&Adapter::OnGattConnected, weak_ptr_factory_.GetWeakPtr(),
+                   callback),
+        base::Bind(&Adapter::OnConnectError, weak_ptr_factory_.GetWeakPtr(),
+                   callback));
+  } else {
+    mojom::ConnectErrorPtr error = mojom::ConnectError::New();
+    error->code = mojom::ConnectError::Code::ERROR_FAILED;
+    callback.Run(std::move(error), nullptr /* Device */);
+  }
 }
 
 void Adapter::GetDevices(const GetDevicesCallback& callback) {
   std::vector<mojom::DeviceInfoPtr> devices;
 
   for (const device::BluetoothDevice* device : adapter_->GetDevices()) {
     mojom::DeviceInfoPtr device_info =
         Device::ConstructDeviceInfoStruct(device);
     devices.push_back(std::move(device_info));
   }
@@ skipping 22 matching lines @@
 }
 
 void Adapter::DeviceChanged(device::BluetoothAdapter* adapter,
                             device::BluetoothDevice* device) {
   if (client_) {
     auto device_info = Device::ConstructDeviceInfoStruct(device);
     client_->DeviceChanged(std::move(device_info));
   }
 }
 
+void Adapter::OnGattConnected(
+    const ConnectToDeviceCallback& callback,
+    std::unique_ptr<device::BluetoothGattConnection> connection) {
+  mojom::DevicePtr device_ptr;
+  mojo::MakeStrongBinding(
+      base::MakeUnique<Device>(adapter_, std::move(connection)),
+      mojo::GetProxy(&device_ptr));
+  callback.Run(nullptr /* ConnectError */, std::move(device_ptr));
+}
+
+void Adapter::OnConnectError(
+    const ConnectToDeviceCallback& callback,
+    device::BluetoothDevice::ConnectErrorCode error_code) {
+  mojom::ConnectErrorPtr error = mojom::ConnectError::New();
+  error->code = static_cast<mojom::ConnectError::Code>(error_code);

[ortuno, 2016/10/25 10:42:09]

Hmmm this is dangerous. Someone could add a new error code and then this would
become undefined. Add a helper method with a switch statement to translate from
ConnectErrorCode to mojo::ConnectError.

[mbrunson, 2016/10/25 20:03:03]

Done.

+  callback.Run(std::move(error), nullptr /* Device */);
+}
 }  // namespace bluetooth