Merge Fix opening App Menu after Bookmarks Drag

Merge Fix opening App Menu after Bookmarks Drag
Fix opening App Menu after Bookmarks Drag

After dragging a nested bookmarks folder to the bookmarks bar, you could not
open the App Menu.

During a Drag operation BookmarkBarView can call Cancel in several
circumstances. If a Cancel was received by MenuController before
OnDragCompleted. Then the internal call to Cancel would not properly teardown
the menu. With an active, but hidden, menu new menus, such as the AppMenu, could
not launch.

This change updates the logic of MenuController::OnDragCompleted to make sure
that teardown occurs.

TBR=sky@chromium.org
NOTRY=true
NOPRESUBMIT=true
TEST=MenuControllerTest.AsynchronousDragComplete, MenuControllerTest.AsynchronousCancelDuringDrag
BUG=656948
Review-Url: https://chromiumcodereview.appspot.com/2433933007
Cr-Commit-Position: refs/heads/master@{#426592}
(cherry picked from commit 6f08e5ae5e67d68510072d6873366a06841064fe)

[jonross, 2016-10-24 21:56:45]

Description was changed from

==========
Merge Fix opening App Menu after Bookmarks Drag
Fix opening App Menu after Bookmarks Drag

After dragging a nested bookmarks folder to the bookmarks bar, you could not
open the App Menu.

During a Drag operation BookmarkBarView can call Cancel in several
circumstances. If a Cancel was received by MenuController before
OnDragCompleted. Then the internal call to Cancel would not properly teardown
the menu. With an active, but hidden, menu new menus, such as the AppMenu, could
not launch.

This change updates the logic of MenuController::OnDragCompleted to make sure
that teardown occurs.

TEST=MenuControllerTest.AsynchronousDragComplete,
MenuControllerTest.AsynchronousCancelDuringDrag
BUG=656948

Review-Url: https://chromiumcodereview.appspot.com/2433933007
Cr-Commit-Position: refs/heads/master@{#426592}
(cherry picked from commit 6f08e5ae5e67d68510072d6873366a06841064fe)
==========

to

==========
Merge Fix opening App Menu after Bookmarks Drag
Fix opening App Menu after Bookmarks Drag

After dragging a nested bookmarks folder to the bookmarks bar, you could not
open the App Menu.

During a Drag operation BookmarkBarView can call Cancel in several
circumstances. If a Cancel was received by MenuController before
OnDragCompleted. Then the internal call to Cancel would not properly teardown
the menu. With an active, but hidden, menu new menus, such as the AppMenu, could
not launch.

This change updates the logic of MenuController::OnDragCompleted to make sure
that teardown occurs.

TBR=sky@chromium.org
NOTRY=true
NOPRESUBMIT=true
TEST=MenuControllerTest.AsynchronousDragComplete,
MenuControllerTest.AsynchronousCancelDuringDrag
BUG=656948

Review-Url: https://chromiumcodereview.appspot.com/2433933007
Cr-Commit-Position: refs/heads/master@{#426592}
(cherry picked from commit 6f08e5ae5e67d68510072d6873366a06841064fe)
==========

[jonross, 2016-10-24 21:56:45]

jonross@chromium.org changed reviewers:
+ sky@chromium.org

[jonross, 2016-10-24 21:56:56]

The CQ bit was checked by jonross@chromium.org

[commit-bot: I haz the power, 2016-10-24 21:57:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 22:01:08]

Description was changed from

==========
Merge Fix opening App Menu after Bookmarks Drag
Fix opening App Menu after Bookmarks Drag

After dragging a nested bookmarks folder to the bookmarks bar, you could not
open the App Menu.

During a Drag operation BookmarkBarView can call Cancel in several
circumstances. If a Cancel was received by MenuController before
OnDragCompleted. Then the internal call to Cancel would not properly teardown
the menu. With an active, but hidden, menu new menus, such as the AppMenu, could
not launch.

This change updates the logic of MenuController::OnDragCompleted to make sure
that teardown occurs.

TBR=sky@chromium.org
NOTRY=true
NOPRESUBMIT=true
TEST=MenuControllerTest.AsynchronousDragComplete,
MenuControllerTest.AsynchronousCancelDuringDrag
BUG=656948

Review-Url: https://chromiumcodereview.appspot.com/2433933007
Cr-Commit-Position: refs/heads/master@{#426592}
(cherry picked from commit 6f08e5ae5e67d68510072d6873366a06841064fe)
==========

to

==========
Merge Fix opening App Menu after Bookmarks Drag
Fix opening App Menu after Bookmarks Drag

After dragging a nested bookmarks folder to the bookmarks bar, you could not
open the App Menu.

During a Drag operation BookmarkBarView can call Cancel in several
circumstances. If a Cancel was received by MenuController before
OnDragCompleted. Then the internal call to Cancel would not properly teardown
the menu. With an active, but hidden, menu new menus, such as the AppMenu, could
not launch.

This change updates the logic of MenuController::OnDragCompleted to make sure
that teardown occurs.

TBR=sky@chromium.org
NOTRY=true
NOPRESUBMIT=true
TEST=MenuControllerTest.AsynchronousDragComplete,
MenuControllerTest.AsynchronousCancelDuringDrag
BUG=656948

Review-Url: https://chromiumcodereview.appspot.com/2433933007
Cr-Commit-Position: refs/heads/master@{#426592}
(cherry picked from commit 6f08e5ae5e67d68510072d6873366a06841064fe)
==========

[commit-bot: I haz the power, 2016-10-24 22:01:09]

Committed patchset #1 (id:1)