Don't run nacl_integration tests on mac.

Don't run nacl_integration tests on mac.

Only two tests remain enabled on Mac in the nacl_integration step.  From the log
output, they are:
[ RUN      ] nacl_newlib.run_breakpad_untrusted_crash_test
[ RUN      ] nacl_newlib.run_inbrowser_test_runner

We have been keeping nacl_integration around because it has some tests that
cover crash reporting.  Without these, we have no integration tests for crash
reporting in Chrome (whether crash reporting is handled via Breakpad, Crashpad
or anything else).  However, most of those tests have been disabled over time
(at least for Mac), and the remaining one (untrusted_crash_test) isn't useful
without the others.

We can live without "inbrowser_test_runner".  It's somewhat useful, but not
worth keeping nacl_integration enabled for.

BUG=626093, 655771, 154400
Committed: https://crrev.com/97d826e88cf1639b0bec80510ec437ea4d3709e1
Cr-Commit-Position: refs/heads/master@{#429058}

[erikchen, 2016-10-24 20:31:28]

erikchen@chromium.org changed reviewers:
+ mark@chromium.org

[Mark Mentovai, 2016-10-24 21:59:53]

I think you’ve talked to mseaborn, but +him to back me up. LGTM.

[erikchen, 2016-10-25 17:41:19]

erikchen@chromium.org changed reviewers:
+ mseaborn@chromium.org

[Mark Seaborn, 2016-10-31 06:04:35]

This is OK, but the description isn't quite accurate.  Some but not all of the
tests in nacl_integration were for testing Chrome's crash reporting (and we
don't really care whether it's Breakpad or something else as long as it works).

A better explanation of the situation would be:

"""
Only two tests remain enabled on Mac in the nacl_integration step.  From the log
output, they are:
[ RUN      ] nacl_newlib.run_breakpad_untrusted_crash_test
[ RUN      ] nacl_newlib.run_inbrowser_test_runner

We had been keeping nacl_integration around because it has some tests that cover
crash reporting.  Without these, we have no integration tests for crash
reporting in Chrome (whether crash reporting is handled via Breakpad, Crashpad
or anything else).  However, most of those tests have got disabled over time (at
least for Mac), and the remaining one (untrusted_crash_test) isn't useful
without the others.

We can live without "inbrowser_test_runner".  It's somewhat useful, but not
worth keeping nacl_integration enabled for.
"""

LGTM if you change the description to include that.

[erikchen, 2016-10-31 19:54:37]

Description was changed from

==========
Don't run nacl_integration tests on mac.

They only exist to test Breakpad, which is no longer used on mac.

BUG=626093
==========

to

==========
Don't run nacl_integration tests on mac.

Only two tests remain enabled on Mac in the nacl_integration step.  From the log
output, they are:
[ RUN      ] nacl_newlib.run_breakpad_untrusted_crash_test
[ RUN      ] nacl_newlib.run_inbrowser_test_runner

We have been keeping nacl_integration around because it has some tests that
cover crash reporting.  Without these, we have no integration tests for crash
reporting in Chrome (whether crash reporting is handled via Breakpad, Crashpad
or anything else).  However, most of those tests have been disabled over time
(at least for Mac), and the remaining one (untrusted_crash_test) isn't useful
without the others.

We can live without "inbrowser_test_runner".  It's somewhat useful, but not
worth keeping nacl_integration enabled for.

BUG=626093
==========

[erikchen, 2016-10-31 19:55:28]

On 2016/10/31 06:04:35, Mark Seaborn wrote:
> This is OK, but the description isn't quite accurate.  Some but not all of the
> tests in nacl_integration were for testing Chrome's crash reporting (and we
> don't really care whether it's Breakpad or something else as long as it
works).
> 
> A better explanation of the situation would be:
> 
> """
> Only two tests remain enabled on Mac in the nacl_integration step.  From the
log
> output, they are:
> [ RUN      ] nacl_newlib.run_breakpad_untrusted_crash_test
> [ RUN      ] nacl_newlib.run_inbrowser_test_runner
> 
> We had been keeping nacl_integration around because it has some tests that
cover
> crash reporting.  Without these, we have no integration tests for crash
> reporting in Chrome (whether crash reporting is handled via Breakpad, Crashpad
> or anything else).  However, most of those tests have got disabled over time
(at
> least for Mac), and the remaining one (untrusted_crash_test) isn't useful
> without the others.
> 
> We can live without "inbrowser_test_runner".  It's somewhat useful, but not
> worth keeping nacl_integration enabled for.
> """
> 
> LGTM if you change the description to include that.

Thanks - updated the description.

[erikchen, 2016-10-31 19:55:45]

erikchen@chromium.org changed reviewers:
+ thakis@chromium.org

[erikchen, 2016-10-31 19:55:45]

thakis: Please review.

[Nico, 2016-11-01 02:24:56]

lgtm, but I don't see how this is related to the linked BUG=. Is that the right
bug?

[Mark Seaborn, 2016-11-01 03:22:21]

On 31 October 2016 at 19:24, <thakis@chromium.org> wrote:

> lgtm, but I don't see how this is related to the linked BUG=. Is that the
> right
> bug?
>

That issue is relevant, but this sub-issue would be better since it
explains more context: https://crbug.com/655771#c4

Also relevant is this: https://crbug.com/154400 (for removing
nacl_integration)

Cheers,
Mark

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[erikchen, 2016-11-01 17:20:51]

Description was changed from

==========
Don't run nacl_integration tests on mac.

Only two tests remain enabled on Mac in the nacl_integration step.  From the log
output, they are:
[ RUN      ] nacl_newlib.run_breakpad_untrusted_crash_test
[ RUN      ] nacl_newlib.run_inbrowser_test_runner

We have been keeping nacl_integration around because it has some tests that
cover crash reporting.  Without these, we have no integration tests for crash
reporting in Chrome (whether crash reporting is handled via Breakpad, Crashpad
or anything else).  However, most of those tests have been disabled over time
(at least for Mac), and the remaining one (untrusted_crash_test) isn't useful
without the others.

We can live without "inbrowser_test_runner".  It's somewhat useful, but not
worth keeping nacl_integration enabled for.

BUG=626093
==========

to

==========
Don't run nacl_integration tests on mac.

Only two tests remain enabled on Mac in the nacl_integration step.  From the log
output, they are:
[ RUN      ] nacl_newlib.run_breakpad_untrusted_crash_test
[ RUN      ] nacl_newlib.run_inbrowser_test_runner

We have been keeping nacl_integration around because it has some tests that
cover crash reporting.  Without these, we have no integration tests for crash
reporting in Chrome (whether crash reporting is handled via Breakpad, Crashpad
or anything else).  However, most of those tests have been disabled over time
(at least for Mac), and the remaining one (untrusted_crash_test) isn't useful
without the others.

We can live without "inbrowser_test_runner".  It's somewhat useful, but not
worth keeping nacl_integration enabled for.

BUG=626093, 655771, 154400
==========

[erikchen, 2016-11-01 17:21:01]

On 2016/11/01 03:22:21, Mark Seaborn wrote:
> On 31 October 2016 at 19:24, <mailto:thakis@chromium.org> wrote:
> 
> > lgtm, but I don't see how this is related to the linked BUG=. Is that the
> > right
> > bug?
> >
> 
> That issue is relevant, but this sub-issue would be better since it
> explains more context: https://crbug.com/655771#c4
> 
> Also relevant is this: https://crbug.com/154400 (for removing
> nacl_integration)
> 
> Cheers,
> Mark
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

Adding both crbug links.

[erikchen, 2016-11-01 17:21:06]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2016-11-01 17:21:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 18:30:10]

Description was changed from

==========
Don't run nacl_integration tests on mac.

Only two tests remain enabled on Mac in the nacl_integration step.  From the log
output, they are:
[ RUN      ] nacl_newlib.run_breakpad_untrusted_crash_test
[ RUN      ] nacl_newlib.run_inbrowser_test_runner

We have been keeping nacl_integration around because it has some tests that
cover crash reporting.  Without these, we have no integration tests for crash
reporting in Chrome (whether crash reporting is handled via Breakpad, Crashpad
or anything else).  However, most of those tests have been disabled over time
(at least for Mac), and the remaining one (untrusted_crash_test) isn't useful
without the others.

We can live without "inbrowser_test_runner".  It's somewhat useful, but not
worth keeping nacl_integration enabled for.

BUG=626093, 655771, 154400
==========

to

==========
Don't run nacl_integration tests on mac.

Only two tests remain enabled on Mac in the nacl_integration step.  From the log
output, they are:
[ RUN      ] nacl_newlib.run_breakpad_untrusted_crash_test
[ RUN      ] nacl_newlib.run_inbrowser_test_runner

We have been keeping nacl_integration around because it has some tests that
cover crash reporting.  Without these, we have no integration tests for crash
reporting in Chrome (whether crash reporting is handled via Breakpad, Crashpad
or anything else).  However, most of those tests have been disabled over time
(at least for Mac), and the remaining one (untrusted_crash_test) isn't useful
without the others.

We can live without "inbrowser_test_runner".  It's somewhat useful, but not
worth keeping nacl_integration enabled for.

BUG=626093, 655771, 154400
==========

[commit-bot: I haz the power, 2016-11-01 18:30:11]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-01 18:54:22]

Description was changed from

==========
Don't run nacl_integration tests on mac.

Only two tests remain enabled on Mac in the nacl_integration step.  From the log
output, they are:
[ RUN      ] nacl_newlib.run_breakpad_untrusted_crash_test
[ RUN      ] nacl_newlib.run_inbrowser_test_runner

We have been keeping nacl_integration around because it has some tests that
cover crash reporting.  Without these, we have no integration tests for crash
reporting in Chrome (whether crash reporting is handled via Breakpad, Crashpad
or anything else).  However, most of those tests have been disabled over time
(at least for Mac), and the remaining one (untrusted_crash_test) isn't useful
without the others.

We can live without "inbrowser_test_runner".  It's somewhat useful, but not
worth keeping nacl_integration enabled for.

BUG=626093, 655771, 154400
==========

to

==========
Don't run nacl_integration tests on mac.

Only two tests remain enabled on Mac in the nacl_integration step.  From the log
output, they are:
[ RUN      ] nacl_newlib.run_breakpad_untrusted_crash_test
[ RUN      ] nacl_newlib.run_inbrowser_test_runner

We have been keeping nacl_integration around because it has some tests that
cover crash reporting.  Without these, we have no integration tests for crash
reporting in Chrome (whether crash reporting is handled via Breakpad, Crashpad
or anything else).  However, most of those tests have been disabled over time
(at least for Mac), and the remaining one (untrusted_crash_test) isn't useful
without the others.

We can live without "inbrowser_test_runner".  It's somewhat useful, but not
worth keeping nacl_integration enabled for.

BUG=626093, 655771, 154400

Committed: https://crrev.com/97d826e88cf1639b0bec80510ec437ea4d3709e1
Cr-Commit-Position: refs/heads/master@{#429058}
==========

[commit-bot: I haz the power, 2016-11-01 18:54:23]

Patchset 1 (id:??) landed as
https://crrev.com/97d826e88cf1639b0bec80510ec437ea4d3709e1
Cr-Commit-Position: refs/heads/master@{#429058}