Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1255)

Unified Diff: content/renderer/render_view_browsertest.cc

Issue 2448543002: Remove dead paint flush tracking code. (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/renderer/document_state.h ('k') | content/renderer/render_view_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_browsertest.cc
diff --git a/content/renderer/render_view_browsertest.cc b/content/renderer/render_view_browsertest.cc
index b7af1d0db0f36852c73d9f52d05a7e277316a882..94c7fa57cd18a8954e3f41f3595fff5bd131176b 100644
--- a/content/renderer/render_view_browsertest.cc
+++ b/content/renderer/render_view_browsertest.cc
@@ -904,30 +904,6 @@ TEST_F(RenderViewImplTest, NavigateProxyAndDetachBeforeOnNavigate) {
provisional_frame->GetWebFrame()->detach();
}
-// Verify that DidFlushPaint doesn't crash if called after a RenderView is
-// swapped out. See https://crbug.com/513552.
-TEST_F(RenderViewImplTest, PaintAfterSwapOut) {
- // Create a new main frame RenderFrame so that we don't interfere with the
- // shutdown of frame() in RenderViewTest.TearDown.
- blink::WebURLRequest popup_request(GURL("http://foo.com"));
- blink::WebView* new_web_view = view()->createView(
- GetMainFrame(), popup_request, blink::WebWindowFeatures(), "foo",
- blink::WebNavigationPolicyNewForegroundTab, false);
- RenderViewImpl* new_view = RenderViewImpl::FromWebView(new_web_view);
-
- // Respond to a swap out request.
- TestRenderFrame* new_main_frame =
- static_cast<TestRenderFrame*>(new_view->GetMainRenderFrame());
- new_main_frame->SwapOut(
- kProxyRoutingId, true,
- ReconstructReplicationStateForTesting(new_main_frame));
-
- // Simulate getting painted after swapping out.
- new_view->DidFlushPaint();
-
- CloseRenderView(new_view);
-}
-
// Verify that the renderer process doesn't crash when device scale factor
// changes after a cross-process navigation has commited.
// See https://crbug.com/571603.
« no previous file with comments | « content/public/renderer/document_state.h ('k') | content/renderer/render_view_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698