Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Unified Diff: media/audio/win/audio_output_win_unittest.cc

Issue 2448533002: Fix 'ordered comparison between pointer and zero' errors (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/win/audio_output_win_unittest.cc
diff --git a/media/audio/win/audio_output_win_unittest.cc b/media/audio/win/audio_output_win_unittest.cc
index 3e868546770ff39879806f6581354f163e062f22..8a131ac5afa972b947fad4e442bad8a39f53dee9 100644
--- a/media/audio/win/audio_output_win_unittest.cc
+++ b/media/audio/win/audio_output_win_unittest.cc
@@ -138,9 +138,7 @@ class ReadOnlyMappedFile {
}
}
// Returns true if the file was successfully mapped.
- bool is_valid() const {
- return ((start_ > 0) && (size_ > 0));
- }
+ bool is_valid() const { return (start_ && (size_ > 0)); }
// Returns the size in bytes of the mapped memory.
uint32_t size() const { return size_; }
// Returns the memory backing the file.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698