Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2448533002: Fix 'ordered comparison between pointer and zero' errors (Closed)

Created:
4 years, 1 month ago by hans
Modified:
4 years, 1 month ago
Reviewers:
justinlin
CC:
chromium-reviews, feature-media-reviews_chromium.org, Nico
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix 'ordered comparison between pointer and zero' errors The latest version of Clang rejects direct relational comparison between null pointer constants and pointers. BUG=none TBR=justinlin Committed: https://crrev.com/ffdb0bdf9bb5304d386a327ba30bb99fb49281d1 Cr-Commit-Position: refs/heads/master@{#427093}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M media/audio/win/audio_output_win_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2448533002/1
4 years, 1 month ago (2016-10-24 16:24:07 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 17:36:50 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 17:50:44 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ffdb0bdf9bb5304d386a327ba30bb99fb49281d1
Cr-Commit-Position: refs/heads/master@{#427093}

Powered by Google App Engine
This is Rietveld 408576698