Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2448493002: Disable flaky test (Closed)

Created:
4 years, 1 month ago by msarett
Modified:
4 years, 1 month ago
Reviewers:
msarett1, Peter Kasting
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable flaky test This test was flaky before. It would just always "succeed" on the second attempt. Now it is still flaky. It just sometimes succeeds outright and sometimes fails on all attempts. I'll disable for now until I can come up with a better fix for these timing issues. NOTRY=true BUG=657839 TEST=none TBR=pkasting@chromium.org Committed: https://crrev.com/962446a4f2a864ea1b94c97b68263213937075be Cr-Commit-Position: refs/heads/master@{#427076}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
msarett1
lgtm
4 years, 1 month ago (2016-10-24 15:10:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2448493002/1
4 years, 1 month ago (2016-10-24 15:11:14 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 15:25:40 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 15:27:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/962446a4f2a864ea1b94c97b68263213937075be
Cr-Commit-Position: refs/heads/master@{#427076}

Powered by Google App Engine
This is Rietveld 408576698