Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 2448473002: Add runtime callstats scopes to some internal accessors (Closed)

Created:
4 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
4 years, 1 month ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add runtime callstats scopes to some internal accessors BUG=v8:5557 R=cbruni@chromium.org Committed: https://crrev.com/b3bdb05f7193d5de8e8b1e5b44c89c049c35afd9 Cr-Commit-Position: refs/heads/master@{#40560}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M src/accessors.cc View 5 chunks +11 lines, -0 lines 0 comments Download
M src/counters.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
jochen (gone - plz use gerrit)
4 years, 1 month ago (2016-10-24 13:38:53 UTC) #1
Camillo Bruni
LGTM let's see how the bots will react to this. I would expect that only ...
4 years, 1 month ago (2016-10-24 20:52:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2448473002/1
4 years, 1 month ago (2016-10-25 12:01:17 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 12:30:57 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:12:29 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b3bdb05f7193d5de8e8b1e5b44c89c049c35afd9
Cr-Commit-Position: refs/heads/master@{#40560}

Powered by Google App Engine
This is Rietveld 408576698