Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 2448463002: [regexp] Remove unused code (Closed)

Created:
4 years, 1 month ago by jgruber
Modified:
4 years, 1 month ago
Reviewers:
Benedikt Meurer, Yang
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, rmcilroy, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Remove unused code This CL removes code that is now unused since the port of regexp.js has been completed. Removed functions / classes are: * regexp.js (GetSubstitution moved to string.js) * RegExpConstructResult stub * RegExpFlags intrinsic * RegExpSource intrinsic * RegExpInitializeAndCompile runtime function BUG=v8:5339 Committed: https://crrev.com/77ddcfb3e095d025e7a5126d398b0493e722dbb9 Cr-Commit-Position: refs/heads/master@{#40547}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -451 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/code-factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/code-factory.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/code-stubs.h View 2 chunks +0 lines, -12 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 2 chunks +0 lines, -32 lines 0 comments Download
M src/compiler/linkage.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/crankshaft/hydrogen.h View 2 chunks +0 lines, -7 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 2 chunks +0 lines, -95 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/interface-descriptors.h View 2 chunks +0 lines, -7 lines 0 comments Download
M src/interpreter/interpreter-intrinsics.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/interpreter/interpreter-intrinsics.cc View 1 chunk +0 lines, -6 lines 0 comments Download
D src/js/regexp.js View 1 chunk +0 lines, -105 lines 0 comments Download
M src/js/string.js View 3 chunks +84 lines, -2 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/runtime/runtime-regexp.cc View 1 chunk +0 lines, -49 lines 0 comments Download
M src/s390/interface-descriptors-s390.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/v8.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M test/mjsunit/es6/classes-subclass-builtins.js View 1 chunk +0 lines, -1 line 0 comments Download
D test/mjsunit/regress/regress-409533.js View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
jgruber
4 years, 1 month ago (2016-10-24 13:34:16 UTC) #4
Yang
On 2016/10/24 13:34:16, jgruber wrote: LGTM
4 years, 1 month ago (2016-10-25 07:03:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2448463002/1
4 years, 1 month ago (2016-10-25 07:05:26 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/27210)
4 years, 1 month ago (2016-10-25 07:08:37 UTC) #11
jgruber
+bmeurer for compiler/, crankshaft/ and interpreter/.
4 years, 1 month ago (2016-10-25 07:11:15 UTC) #13
Benedikt Meurer
Awesome, LGTM.
4 years, 1 month ago (2016-10-25 07:12:25 UTC) #14
jgruber
4 years, 1 month ago (2016-10-25 07:16:09 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2448463002/1
4 years, 1 month ago (2016-10-25 07:16:26 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 07:18:34 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:11:53 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/77ddcfb3e095d025e7a5126d398b0493e722dbb9
Cr-Commit-Position: refs/heads/master@{#40547}

Powered by Google App Engine
This is Rietveld 408576698