Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2448453004:
scale video threads with resolution (Closed)
Descriptionscale video threads with resolution
This allows 4k video to play smoothly on high-end machines, even when software-decoded.
Most machines today have 2-8 execution contexts, using
more cores generally doesn't seem to increase power usage
and allows us to decode video faster.
The number of threads we use proportional to the number of pixels, normalized so that 1080p gets three threads.
Examples:
4k: 12 threads
1440p: 5 threads
1080p: 3 threads
anything lower than 1080p: 2 threads
BUG=
Committed: https://crrev.com/c99cc371fad707aed0f0e3d90b889be24e907b91
Cr-Commit-Position: refs/heads/master@{#428214}
Patch Set 1 #Patch Set 2 : always slice #Patch Set 3 : bugfix #Patch Set 4 : comment update #
Total comments: 4
Patch Set 5 : comments updated #Messages
Total messages: 31 (23 generated)
The CQ bit was checked by hubbe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by hubbe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by hubbe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by hubbe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
hubbe@chromium.org changed reviewers: + dalecurtis@google.com
dalecurtis@chromium.org changed reviewers: + dalecurtis@chromium.org
https://codereview.chromium.org/2448453004/diff/60001/media/filters/ffmpeg_vi... File media/filters/ffmpeg_video_decoder.cc (right): https://codereview.chromium.org/2448453004/diff/60001/media/filters/ffmpeg_vi... media/filters/ffmpeg_video_decoder.cc:32: // Always try to use three threads for video decoding. There is little reason Ahem :) https://codereview.chromium.org/2448453004/diff/60001/media/filters/ffmpeg_vi... media/filters/ffmpeg_video_decoder.cc:53: decode_threads = config.coded_size().width() * Logic needs a description and some example values.
The CQ bit was checked by hubbe@chromium.org to run a CQ dry run
https://codereview.chromium.org/2448453004/diff/60001/media/filters/ffmpeg_vi... File media/filters/ffmpeg_video_decoder.cc (right): https://codereview.chromium.org/2448453004/diff/60001/media/filters/ffmpeg_vi... media/filters/ffmpeg_video_decoder.cc:32: // Always try to use three threads for video decoding. There is little reason On 2016/10/27 18:11:34, DaleCurtis wrote: > Ahem :) Comment updated. https://codereview.chromium.org/2448453004/diff/60001/media/filters/ffmpeg_vi... media/filters/ffmpeg_video_decoder.cc:53: decode_threads = config.coded_size().width() * On 2016/10/27 18:11:34, DaleCurtis wrote: > Logic needs a description and some example values. Done.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
Please copy some of the comment text into the commit message.
Description was changed from ========== scale video threads with resolution this allows 4k video to play smoothly on high-end machines, even when software-decoded. BUG= ========== to ========== scale video threads with resolution This allows 4k video to play smoothly on high-end machines, even when software-decoded. Most machines today have 2-8 execution contexts, using more cores generally doesn't seem to increase power usage and allows us to decode video faster. The number of threads we use proportional to the number of pixels, normalized so that 1080p gets three threads. Examples: 4k: 12 threads 1440p: 5 threads 1080p: 3 threads anything lower than 1080p: 2 threads BUG= ==========
The CQ bit was unchecked by hubbe@chromium.org
The CQ bit was checked by hubbe@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== scale video threads with resolution This allows 4k video to play smoothly on high-end machines, even when software-decoded. Most machines today have 2-8 execution contexts, using more cores generally doesn't seem to increase power usage and allows us to decode video faster. The number of threads we use proportional to the number of pixels, normalized so that 1080p gets three threads. Examples: 4k: 12 threads 1440p: 5 threads 1080p: 3 threads anything lower than 1080p: 2 threads BUG= ========== to ========== scale video threads with resolution This allows 4k video to play smoothly on high-end machines, even when software-decoded. Most machines today have 2-8 execution contexts, using more cores generally doesn't seem to increase power usage and allows us to decode video faster. The number of threads we use proportional to the number of pixels, normalized so that 1080p gets three threads. Examples: 4k: 12 threads 1440p: 5 threads 1080p: 3 threads anything lower than 1080p: 2 threads BUG= ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== scale video threads with resolution This allows 4k video to play smoothly on high-end machines, even when software-decoded. Most machines today have 2-8 execution contexts, using more cores generally doesn't seem to increase power usage and allows us to decode video faster. The number of threads we use proportional to the number of pixels, normalized so that 1080p gets three threads. Examples: 4k: 12 threads 1440p: 5 threads 1080p: 3 threads anything lower than 1080p: 2 threads BUG= ========== to ========== scale video threads with resolution This allows 4k video to play smoothly on high-end machines, even when software-decoded. Most machines today have 2-8 execution contexts, using more cores generally doesn't seem to increase power usage and allows us to decode video faster. The number of threads we use proportional to the number of pixels, normalized so that 1080p gets three threads. Examples: 4k: 12 threads 1440p: 5 threads 1080p: 3 threads anything lower than 1080p: 2 threads BUG= Committed: https://crrev.com/c99cc371fad707aed0f0e3d90b889be24e907b91 Cr-Commit-Position: refs/heads/master@{#428214} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/c99cc371fad707aed0f0e3d90b889be24e907b91 Cr-Commit-Position: refs/heads/master@{#428214} |
