Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: build/config/compiler/compiler.gni

Issue 2448453002: Move ignore_elf32_limitations into build_overrides/build.gni (Closed)
Patch Set: Made it a gn arg Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build_overrides/build.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/chromecast_build.gni") 7 import("//build/config/chromecast_build.gni")
8 import("//build/config/sanitizers/sanitizers.gni") 8 import("//build/config/sanitizers/sanitizers.gni")
9 import("//build/toolchain/goma.gni") 9 import("//build/toolchain/goma.gni")
10 import("//build/toolchain/toolchain.gni") 10 import("//build/toolchain/toolchain.gni")
11 import("//build_overrides/build.gni")
11 12
12 declare_args() { 13 declare_args() {
13 # How many symbols to include in the build. This affects the performance of 14 # How many symbols to include in the build. This affects the performance of
14 # the build since the symbols are large and dealing with them is slow. 15 # the build since the symbols are large and dealing with them is slow.
15 # 2 means regular build with symbols. 16 # 2 means regular build with symbols.
16 # 1 means minimal symbols, usually enough for backtraces only. 17 # 1 means minimal symbols, usually enough for backtraces only.
17 # 0 means no symbols. 18 # 0 means no symbols.
18 # -1 means auto-set according to debug/release and platform. 19 # -1 means auto-set according to debug/release and platform.
19 symbol_level = -1 20 symbol_level = -1
20 21
(...skipping 19 matching lines...) Expand all
40 is_win_fastlink = false 41 is_win_fastlink = false
41 42
42 # Specify the current PGO phase, only used for the Windows MSVS build. Here's 43 # Specify the current PGO phase, only used for the Windows MSVS build. Here's
43 # the different values that can be used: 44 # the different values that can be used:
44 # 0 : Means that PGO is turned off. 45 # 0 : Means that PGO is turned off.
45 # 1 : Used during the PGI (instrumentation) phase. 46 # 1 : Used during the PGI (instrumentation) phase.
46 # 2 : Used during the PGO (optimization) phase. 47 # 2 : Used during the PGO (optimization) phase.
47 # 48 #
48 # TODO(sebmarchand): Add support for the PGU (update) phase. 49 # TODO(sebmarchand): Add support for the PGU (update) phase.
49 chrome_pgo_phase = 0 50 chrome_pgo_phase = 0
50
51 # Android 32-bit non-component, non-clang builds cannot have symbol_level=2
52 # due to 4GiB file size limit, see https://crbug.com/648948.
53 # Set this flag to true to skip the assertion.
54 ignore_elf32_limitations = false
55 } 51 }
56 52
57 declare_args() { 53 declare_args() {
58 # Whether or not the official builds should be built with full WPO. Enabled by 54 # Whether or not the official builds should be built with full WPO. Enabled by
59 # default for the PGO and the x64 builds. 55 # default for the PGO and the x64 builds.
60 if (chrome_pgo_phase > 0) { 56 if (chrome_pgo_phase > 0) {
61 full_wpo_on_official = true 57 full_wpo_on_official = true
62 } else { 58 } else {
63 full_wpo_on_official = false 59 full_wpo_on_official = false
64 } 60 }
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 symbol_level = 0 96 symbol_level = 0
101 } 97 }
102 } 98 }
103 99
104 # Assert that the configuration isn't going to hit https://crbug.com/648948. 100 # Assert that the configuration isn't going to hit https://crbug.com/648948.
105 assert(ignore_elf32_limitations || !is_android || android_64bit_target_cpu || 101 assert(ignore_elf32_limitations || !is_android || android_64bit_target_cpu ||
106 is_component_build || symbol_level < 2 || is_clang, 102 is_component_build || symbol_level < 2 || is_clang,
107 "Android 32-bit non-component, non-clang builds cannot have " + 103 "Android 32-bit non-component, non-clang builds cannot have " +
108 "symbol_level=2 due to 4GiB file size limit, see " + 104 "symbol_level=2 due to 4GiB file size limit, see " +
109 "https://crbug.com/648948") 105 "https://crbug.com/648948")
OLDNEW
« no previous file with comments | « no previous file | build_overrides/build.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698