Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2448443002: Revert of [compiler] Prepare for partially shipping Ignition. (Closed)

Created:
4 years, 1 month ago by Michael Starzinger
Modified:
4 years, 1 month ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [compiler] Prepare for partially shipping Ignition. (patchset #1 id:1 of https://codereview.chromium.org/2443573002/ ) Reason for revert: Causes regressions: https://bugs.chromium.org/p/chromium/issues/detail?id=658711 Original issue's description: > [compiler] Prepare for partially shipping Ignition. > > This prepares the code-base so that Ignition can be enabled on a certain > subset of compilations without setting the {FLAG_ignition} flag (which > enables Ignition on all compilations). We should not check the flag in > question explicitly anywhere outside of the compiler heuristics. > > R=mvstanton@chromium.org BUG=chromium:658711 TBR=mvstanton@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://crrev.com/6dd0587be31034b958762d60f7aa6ada66b8a3b8 Cr-Commit-Position: refs/heads/master@{#40534}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -19 lines) Patch
M src/api.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M src/compiler-dispatcher/compiler-dispatcher-job.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M src/d8.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/frames.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ic.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/isolate.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/log.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/test-log-stack-tracer.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Michael Starzinger
Created Revert of [compiler] Prepare for partially shipping Ignition.
4 years, 1 month ago (2016-10-24 12:33:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2448443002/1
4 years, 1 month ago (2016-10-24 12:33:52 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 13:02:13 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:11:11 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6dd0587be31034b958762d60f7aa6ada66b8a3b8
Cr-Commit-Position: refs/heads/master@{#40534}

Powered by Google App Engine
This is Rietveld 408576698