Issue 244843002: Update SocketStreamConnectionType enum definition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 244843002: Update SocketStreamConnectionType enum definition (Closed)

Created:
6 years, 8 months ago by tyoshino (SeeGerritForStatus)

Modified:
6 years, 8 months ago

Reviewers:
Alexei Svitkine (slow), yhirano

CC:
chromium-reviews, jar (doing other things), asvitkine+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Update SocketStreamConnectionType enum definition - Definition for SECURE_PROXY_CONNECTION is missing - "connection" is redundant. Remove it from all description texts BUG=none R=asvitkine@chromium.org, yhirano@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266138

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -5 lines)			Patch
	M	tools/metrics/histograms/histograms.xml	View		1 chunk	+6 lines, -5 lines	0 comments	Download

Total messages: 5 (0 generated)

Alexei Svitkine (slow)

LGTM. In the future, it's a good idea to include the histograms.xml changes in the ...

6 years, 8 months ago (2014-04-22 14:57:52 UTC) #3

tyoshino (SeeGerritForStatus)

On 2014/04/22 14:57:52, Alexei Svitkine wrote: > LGTM. > > In the future, it's a ...

6 years, 8 months ago (2014-04-23 03:33:33 UTC) #4

tyoshino (SeeGerritForStatus)

6 years, 8 months ago (2014-04-25 06:13:22 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r266138 (presubmit successful).