Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 24484003: Let timer test retry for 20ms to reduce flakiness. (Closed)

Created:
7 years, 2 months ago by Michael Achenbach
Modified:
7 years, 2 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev, Hannes Payer (out of office)
Visibility:
Public.

Description

Let timer test retry for 20ms to reduce flakiness. BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16948

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M test/mjsunit/timer.js View 1 1 chunk +17 lines, -6 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
PTAL
7 years, 2 months ago (2013-09-25 15:34:14 UTC) #1
Jakob Kummerow
LGTM with comments. Thanks for fixing this! https://codereview.chromium.org/24484003/diff/1/test/mjsunit/timer.js File test/mjsunit/timer.js (right): https://codereview.chromium.org/24484003/diff/1/test/mjsunit/timer.js#newcode30 test/mjsunit/timer.js:30: (function run(){ ...
7 years, 2 months ago (2013-09-25 16:16:23 UTC) #2
Michael Achenbach
Committed patchset #2 manually as r16948 (presubmit successful).
7 years, 2 months ago (2013-09-25 16:48:07 UTC) #3
Jakob Kummerow
7 years, 2 months ago (2013-09-25 17:11:55 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/24484003/diff/6001/test/mjsunit/timer.js
File test/mjsunit/timer.js (right):

https://codereview.chromium.org/24484003/diff/6001/test/mjsunit/timer.js#newc...
test/mjsunit/timer.js:32: // Let the retry run for maximum 20ms to reduce
flakiness.
Should have updated this comment (and the CL description) too ;-)

Powered by Google App Engine
This is Rietveld 408576698