Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2448373003: Convert editing/execCommand/format-block.html to utilize w3c test harness (Closed)

Created:
4 years, 1 month ago by yosin_UTC9
Modified:
4 years, 1 month ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/deleting/format-block.html to utilize w3c test harness This patch converts "format-block.html" to utilize w3c test harness with |assert_selection()| to simplify test case for improving code health. This patch is a preparation of http://crrev.com/1958093002 BUG=625533 TEST=n/a; no behavior changes Committed: https://crrev.com/9bb574d303c5d83a913f752a8c6b7e0b45ee07a4 Cr-Commit-Position: refs/heads/master@{#427651}

Patch Set 1 : 2016-10-26T14:32:42 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -99 lines) Patch
M third_party/WebKit/LayoutTests/editing/execCommand/format-block.html View 1 chunk +24 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/execCommand/format-block-expected.txt View 1 chunk +0 lines, -69 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
yosin_UTC9
PTAL
4 years, 1 month ago (2016-10-26 06:09:43 UTC) #5
Xiaocheng
lgtm
4 years, 1 month ago (2016-10-26 09:24:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2448373003/1
4 years, 1 month ago (2016-10-26 09:38:19 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 09:43:18 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 09:45:01 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9bb574d303c5d83a913f752a8c6b7e0b45ee07a4
Cr-Commit-Position: refs/heads/master@{#427651}

Powered by Google App Engine
This is Rietveld 408576698