Issue 244833003: SPDY tests: Additional headers validation in framer tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 244833003: SPDY tests: Additional headers validation in framer tests. (Closed)

Created:
6 years, 8 months ago by Johnny

Modified:
6 years, 7 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

SPDY tests: Additional headers validation in framer tests. Server change also included logic to lower-case headers and error on responses with incorrect casing. This wasn't merged, as Chromium instead has handling and tests on this in SpdyStream. This lands server change 63898388 by mlavan. BUG=345769

Patch Set 1 #

Patch Set 2 : Back out header casing & checks. Build fix. #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -5 lines)			Patch
	M	net/spdy/spdy_framer_test.cc	View	1	3 chunks	+35 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Johnny

6 years, 8 months ago (2014-04-23 17:33:07 UTC) #3

FYI: I backed out much of the header casing logic, and left only the extra test
validation this CL introduced.

SpdyStream has equivalent casing checks and testing, which this CL otherwise
breaks. There isn't a good way to have both and I don't think we need it.

Expand Messages | Collapse Messages