Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 2448323004: [Interpreter] Don't require a CanonicalHandleScope for parse / renumbering (Closed)

Created:
4 years, 1 month ago by rmcilroy
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Don't require a CanonicalHandleScope for parse / renumbering Removes the need for a CanonicalHandleScope for parsing and renumbering phases when using Ignition. Since AST strings are canonicalized by the AST value factory, we only need to make sure we use the same canonical handles for any other handles we add to the bytecode generator. This avoids a regression when enabling Ignition for all Turbofan code, and improves CodeLoad on for Ignition by about 5%. BUG=v8:4280 Committed: https://crrev.com/7db6c79acd6ccf45984275136e8c58c4be0f0fd9 Cr-Commit-Position: refs/heads/master@{#40595}

Patch Set 1 #

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -50 lines) Patch
M src/api.cc View 1 chunk +4 lines, -12 lines 0 comments Download
M src/compiler.cc View 7 chunks +8 lines, -22 lines 0 comments Download
M src/compiler-dispatcher/compiler-dispatcher-job.cc View 1 chunk +3 lines, -11 lines 0 comments Download
M src/interpreter/bytecode-generator.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 3 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
rmcilroy
Michi / Leszek, PTAL, thanks.
4 years, 1 month ago (2016-10-26 14:02:52 UTC) #6
Michael Starzinger
LGTM. Thanks!
4 years, 1 month ago (2016-10-26 14:35:53 UTC) #9
Leszek Swirski
lgtm
4 years, 1 month ago (2016-10-26 14:36:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2448323004/20001
4 years, 1 month ago (2016-10-26 15:08:38 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-26 15:11:06 UTC) #13
Toon Verwaest
Awesome! :-)
4 years, 1 month ago (2016-10-26 16:09:31 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:14:15 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7db6c79acd6ccf45984275136e8c58c4be0f0fd9
Cr-Commit-Position: refs/heads/master@{#40595}

Powered by Google App Engine
This is Rietveld 408576698