Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2448303002: Rewrite git gclient sync/update to be simpler and more reliable (Closed)

Created:
4 years, 1 month ago by agable
Modified:
3 years, 8 months ago
Reviewers:
iannucci, M-A Ruel
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rewrite git gclient sync/update to be simpler and more reliable This does two main things for the GitWrapper:update() (a.k.a. gclient sync) routine: * Linearizes much of the flow, so that early failure cases result in aborts rather than wasted effort, and it is easier to understand * Ensures that a 'fetch' is run early on, so that we can guarantee that the target revision is either available, or entirely unfetchable, and proceed appropriately. R=iannucci@chromium.org, maruel@chromium.org BUG=643346

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -144 lines) Patch
M gclient_scm.py View 13 chunks +152 lines, -144 lines 0 comments Download

Messages

Total messages: 5 (5 generated)
agable
The CQ bit was checked by agable@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-19 23:13:19 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2448303002/1
3 years, 11 months ago (2017-01-19 23:13:28 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-19 23:19:56 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Depot Tools Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/33d1d65355ce0710)
3 years, 11 months ago (2017-01-19 23:19:57 UTC) #4
agable
3 years, 8 months ago (2017-04-18 18:39:52 UTC) #5
Description was changed from

==========
Rewrite git gclient sync/update to be simpler and more reliable

This does two main things for the GitWrapper:update() (a.k.a.
gclient sync) routine:
* Linearizes much of the flow, so that early failure cases result
  in aborts rather than wasted effort, and it is easier to understand
* Ensures that a 'fetch' is run early on, so that we can guarantee that
  the target revision is either available, or entirely unfetchable, and
  proceed appropriately.

R=iannucci@chromium.org, maruel@chromium.org
BUG=643346
==========

to

==========
Rewrite git gclient sync/update to be simpler and more reliable

This does two main things for the GitWrapper:update() (a.k.a.
gclient sync) routine:
* Linearizes much of the flow, so that early failure cases result
  in aborts rather than wasted effort, and it is easier to understand
* Ensures that a 'fetch' is run early on, so that we can guarantee that
  the target revision is either available, or entirely unfetchable, and
  proceed appropriately.

R=iannucci@chromium.org, maruel@chromium.org
BUG=643346
==========

Powered by Google App Engine
This is Rietveld 408576698