Make DOMParser::parseFromString specification compliant and throw exception in error scenario.

Make DOMParser::parseFromString specification compliant and throw exception in error scenario.

Make DOMParser::parseFromString() allow only the supported mime-types by specification -
http://domparsing.spec.whatwg.org/#the-domparser-interface

In case of wrong mime type or mixed case mimetype as specified in the specification,
throw TypeError exception. Throwing exception can be seen implemented by FF and Opera 12.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158452

[vivekg__, 2013-09-25 23:34:46]

Please take a look, thank you!

[eseidel, 2013-09-26 16:37:07]

Does IE not throw this exception? If not, this could be a compat worry, but I
doubt it. :)

https://codereview.chromium.org/24483007/diff/4001/Source/core/xml/DOMParser.cpp
File Source/core/xml/DOMParser.cpp (right):

https://codereview.chromium.org/24483007/diff/4001/Source/core/xml/DOMParser....
Source/core/xml/DOMParser.cpp:30: if (contentType != "text/html"
I might have put a comment and link to the spec:

// HTML5 is very explicit about which 5 types we're allowed to support here
// link-to-the-spec.

[eseidel, 2013-09-26 16:37:15]

lgtm

[vivekg__, 2013-09-26 18:17:14]

On 2013/09/26 16:37:07, eseidel wrote:
> Does IE not throw this exception? If not, this could be a compat worry, but I
> doubt it. :)
> 

Yes, IE throws an invalid argument error in case its not supported.

IE supports only 4 types leaving out "text/html" as documented here:
http://msdn.microsoft.com/en-us/library/ie/ff975278(v=vs.85).aspx

Also IE supports case insensitive handling of the supported mime types.

>
https://codereview.chromium.org/24483007/diff/4001/Source/core/xml/DOMParser.cpp
> File Source/core/xml/DOMParser.cpp (right):
> 
>
https://codereview.chromium.org/24483007/diff/4001/Source/core/xml/DOMParser....
> Source/core/xml/DOMParser.cpp:30: if (contentType != "text/html"
> I might have put a comment and link to the spec:
> 
> // HTML5 is very explicit about which 5 types we're allowed to support here
> // link-to-the-spec.

Done. Thank you!

[eseidel, 2013-09-26 20:18:26]

https://codereview.chromium.org/24483007/diff/10001/Source/core/xml/DOMParser...
File Source/core/xml/DOMParser.cpp (right):

https://codereview.chromium.org/24483007/diff/10001/Source/core/xml/DOMParser...
Source/core/xml/DOMParser.cpp:37: es.throwDOMException(TypeError);
I think the name of this function is about to change.  You might consider usign
the flavor which allows us to throw a nice message as well.

[vivekg__, 2013-09-27 10:52:28]

On 2013/09/26 20:18:26, eseidel wrote:
>
https://codereview.chromium.org/24483007/diff/10001/Source/core/xml/DOMParser...
> File Source/core/xml/DOMParser.cpp (right):
> 
>
https://codereview.chromium.org/24483007/diff/10001/Source/core/xml/DOMParser...
> Source/core/xml/DOMParser.cpp:37: es.throwDOMException(TypeError);
> I think the name of this function is about to change.  You might consider
usign
> the flavor which allows us to throw a nice message as well.

Yeah, you are right! Mike (mkwst) is doing away with the basic standard messages
in case of error was thrown.
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/sQrOdPajiIA

As per this, the method throwDOMExcpetion with just one argument is prohibited.
Done changes to be more descriptive of the error. Please have a look.

[eseidel, 2013-09-27 14:49:46]

lgtm

[commit-bot: I haz the power, 2013-09-27 14:50:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/24483007/20001

[commit-bot: I haz the power, 2013-09-27 16:04:38]

Change committed as 158452