Name core/fxge/android files appropriately and use one file per class

Name core/fxge/android files appropriately and use one file per class

- Rename files so that they correspond to class names.
- Remove OS_Android ifs, since they are unneeded.
- Split fpf_skiafontmgr.h into classes, one per file.

Committed: https://pdfium.googlesource.com/pdfium/+/cfcc11e53a60b3f56a9bbe13718ecb9b997384da

[npm, 2016-10-25 20:43:06]

The CQ bit was checked by npm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 20:43:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 20:48:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 20:48:10]

Dry run: Try jobs failed on following builders:
  android on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/android/builds/...)

[npm, 2016-10-25 20:58:21]

The CQ bit was checked by npm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 20:58:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[npm, 2016-10-25 21:04:48]

Description was changed from

==========
Name core/fxge/android files appropriately and use one file per class

- Rename files so that they correspond to class names.
- Remove OS_Android ifs, since they are unneeded.
- Split fpf_skiafontmgr.h into classes, one per file.
==========

to

==========
Name core/fxge/android files appropriately and use one file per class

- Rename files so that they correspond to class names.
- Remove OS_Android ifs, since they are unneeded.
- Split fpf_skiafontmgr.h into classes, one per file.
==========

[npm, 2016-10-25 21:04:48]

npm@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org, weili@chromium.org

[npm, 2016-10-25 21:06:53]

PTAL

[Tom Sepez, 2016-10-25 21:14:14]

lgtm

https://codereview.chromium.org/2448293002/diff/20001/core/fxge/android/cfpf_...
File core/fxge/android/cfpf_skiafontdescriptor.h (right):

https://codereview.chromium.org/2448293002/diff/20001/core/fxge/android/cfpf_...
core/fxge/android/cfpf_skiafontdescriptor.h:27: FX_Free(m_pFamily);
follow-up: use some sort of string class (e.g. CFX_ByteString here).

https://codereview.chromium.org/2448293002/diff/20001/core/fxge/android/cfpf_...
File core/fxge/android/cfpf_skiapathfont.h (right):

https://codereview.chromium.org/2448293002/diff/20001/core/fxge/android/cfpf_...
core/fxge/android/cfpf_skiapathfont.h:24: FX_Free(m_pPath);
follow-up: ditto

[commit-bot: I haz the power, 2016-10-25 21:24:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 21:24:42]

Dry run: This issue passed the CQ dry run.

[npm, 2016-10-25 21:26:06]

https://codereview.chromium.org/2448293002/diff/20001/core/fxge/android/cfpf_...
File core/fxge/android/cfpf_skiafontdescriptor.h (right):

https://codereview.chromium.org/2448293002/diff/20001/core/fxge/android/cfpf_...
core/fxge/android/cfpf_skiafontdescriptor.h:27: FX_Free(m_pFamily);
On 2016/10/25 21:14:14, Tom Sepez wrote:
> follow-up: use some sort of string class (e.g. CFX_ByteString here).

Acknowledged

[npm, 2016-10-25 21:26:17]

The CQ bit was checked by npm@chromium.org

[commit-bot: I haz the power, 2016-10-25 21:26:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 21:26:42]

Description was changed from

==========
Name core/fxge/android files appropriately and use one file per class

- Rename files so that they correspond to class names.
- Remove OS_Android ifs, since they are unneeded.
- Split fpf_skiafontmgr.h into classes, one per file.
==========

to

==========
Name core/fxge/android files appropriately and use one file per class

- Rename files so that they correspond to class names.
- Remove OS_Android ifs, since they are unneeded.
- Split fpf_skiafontmgr.h into classes, one per file.

Committed:
https://pdfium.googlesource.com/pdfium/+/cfcc11e53a60b3f56a9bbe13718ecb9b9973...
==========

[commit-bot: I haz the power, 2016-10-25 21:26:43]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/cfcc11e53a60b3f56a9bbe13718ecb9b9973...