Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2448273002: [inspector_protocol] initial commit (Closed)

Created:
4 years, 1 month ago by kozy
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[inspector_protocol] initial commit Copy inspector_protocol folder from chromium/src/third_party/WebKit/platform/inspector_protocol. BUG=chromium:637032 R=dgozman@chromium.org Committed: https://chromium.googlesource.com/deps/inspector_protocole2d4610272c4ee2f93d999fe34a4c91b1b0dd335

Patch Set 1 : updated Readme.chromium #

Total comments: 2

Patch Set 2 : added watchlist #

Patch Set 3 : removed README.chromium #

Total comments: 8

Patch Set 4 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4227 lines, -0 lines) Patch
A CheckProtocolCompatibility.py View 1 chunk +479 lines, -0 lines 0 comments Download
A CodeGenerator.py View 1 chunk +499 lines, -0 lines 0 comments Download
A ConcatenateProtocols.py View 1 chunk +39 lines, -0 lines 0 comments Download
A LICENSE View 1 chunk +27 lines, -0 lines 0 comments Download
A OWNERS View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
A WATCHLISTS View 1 2 3 1 chunk +19 lines, -0 lines 0 comments Download
A inspector_protocol.gni View 1 chunk +82 lines, -0 lines 0 comments Download
A inspector_protocol.gypi View 1 2 3 1 chunk +34 lines, -0 lines 0 comments Download
A lib/Allocator_h.template View 1 chunk +30 lines, -0 lines 0 comments Download
A lib/Array_h.template View 1 chunk +136 lines, -0 lines 0 comments Download
A lib/BackendCallback_h.template View 1 chunk +24 lines, -0 lines 0 comments Download
A lib/Collections_h.template View 1 chunk +43 lines, -0 lines 0 comments Download
A lib/DispatcherBase_cpp.template View 1 chunk +173 lines, -0 lines 0 comments Download
A lib/DispatcherBase_h.template View 1 chunk +97 lines, -0 lines 0 comments Download
A lib/ErrorSupport_cpp.template View 1 chunk +70 lines, -0 lines 0 comments Download
A lib/ErrorSupport_h.template View 1 chunk +37 lines, -0 lines 0 comments Download
A lib/Forward_h.template View 1 chunk +37 lines, -0 lines 0 comments Download
A lib/FrontendChannel_h.template View 1 chunk +24 lines, -0 lines 0 comments Download
A lib/Maybe_h.template View 1 chunk +80 lines, -0 lines 0 comments Download
A lib/Object_cpp.template View 1 chunk +37 lines, -0 lines 0 comments Download
A lib/Object_h.template View 1 chunk +32 lines, -0 lines 0 comments Download
A lib/Parser_cpp.template View 1 chunk +553 lines, -0 lines 0 comments Download
A lib/Parser_h.template View 1 chunk +22 lines, -0 lines 0 comments Download
A lib/Protocol_cpp.template View 1 chunk +12 lines, -0 lines 0 comments Download
A lib/ValueConversions_h.template View 1 chunk +171 lines, -0 lines 0 comments Download
A lib/Values_cpp.template View 1 chunk +407 lines, -0 lines 0 comments Download
A lib/Values_h.template View 1 chunk +246 lines, -0 lines 0 comments Download
A sample_config.json View 1 chunk +39 lines, -0 lines 0 comments Download
A sample_expected_errors.json View 1 chunk +7 lines, -0 lines 0 comments Download
A templates/Exported_h.template View 1 chunk +65 lines, -0 lines 0 comments Download
A templates/Imported_h.template View 1 chunk +51 lines, -0 lines 0 comments Download
A templates/TypeBuilder_cpp.template View 1 chunk +359 lines, -0 lines 0 comments Download
A templates/TypeBuilder_h.template View 1 chunk +290 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kozy
Dmitry, please take a look. https://codereview.chromium.org/2448273002/diff/20001/LICENSE File LICENSE (right): https://codereview.chromium.org/2448273002/diff/20001/LICENSE#newcode1 LICENSE:1: // Copyright 2016 The ...
4 years, 1 month ago (2016-10-25 20:41:12 UTC) #2
kozy
Dmitry, please take another look. Removed README.chromium and duplicates.
4 years, 1 month ago (2016-10-25 21:43:40 UTC) #3
dgozman
lgtm https://codereview.chromium.org/2448273002/diff/60001/OWNERS File OWNERS (right): https://codereview.chromium.org/2448273002/diff/60001/OWNERS#newcode1 OWNERS:1: alph@chromium.org set noparent https://codereview.chromium.org/2448273002/diff/60001/WATCHLISTS File WATCHLISTS (right): https://codereview.chromium.org/2448273002/diff/60001/WATCHLISTS#newcode1 ...
4 years, 1 month ago (2016-10-25 21:48:13 UTC) #4
kozy
thanks! all done. https://codereview.chromium.org/2448273002/diff/60001/OWNERS File OWNERS (right): https://codereview.chromium.org/2448273002/diff/60001/OWNERS#newcode1 OWNERS:1: alph@chromium.org On 2016/10/25 21:48:13, dgozman wrote: ...
4 years, 1 month ago (2016-10-25 23:23:57 UTC) #5
kozy
4 years, 1 month ago (2016-10-25 23:25:03 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:80001) manually as
e2d4610272c4ee2f93d999fe34a4c91b1b0dd335 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698